Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Jetpack connection delegates to weak references #21052

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Change Jetpack connection delegates to weak references #21052

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e910b4c
Change Jetpack connection delegates to weak references
crazytonyli Jul 11, 2023
58959a3
Add PR number to a release note
crazytonyli Jul 11, 2023
caa352f
Change scanningDelegate to a weak reference
crazytonyli Jul 11, 2023
c8ead53
Merge branch 'trunk' into weak-delegate-violation-fixes-2
crazytonyli Jul 19, 2023
e21ebb4
Update release notes
crazytonyli Jul 19, 2023
22389b1
Merge branch 'trunk' into weak-delegate-violation-fixes-2
crazytonyli Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
22.9
-----
* [*] Fix memory leaks in setting up Jetpack connection. [#21052]

22.8
-----
* [*] Blogging Reminders: Disabled prompt for self-hosted sites not connected to Jetpack. [#20970]
Expand Down
4 changes: 2 additions & 2 deletions ...ress/Classes/ViewRelated/Jetpack/Install/Webview/JetpackConnectionWebViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Gridicons
import WordPressAuthenticator
import Combine

protocol JetpackConnectionWebDelegate {
protocol JetpackConnectionWebDelegate: AnyObject {
func jetpackConnectionCompleted()
func jetpackConnectionCanceled()
}
Expand All @@ -13,7 +13,7 @@ class JetpackConnectionWebViewController: UIViewController {
let blog: Blog
let webView: WKWebView
let progressView = WebProgressView()
var delegate: JetpackConnectionWebDelegate?
weak var delegate: JetpackConnectionWebDelegate?

// Sometimes wp-login doesn't redirect to the expected URL, so we're storing
// it and redirecting manually
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackConnectionViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ open class JetpackConnectionViewController: UITableViewController {

// MARK: - Public Properties

@objc var delegate: JetpackConnectionDelegate?
@objc weak var delegate: JetpackConnectionDelegate?

// MARK: - Initializer

Expand Down