New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some "delegate" instances are incorrectly declared as strong references #21050

Closed

crazytonyli opened this issue Jul 11, 2023 · 0 comments · Fixed by #21068

Assignees

Labels

Contributor

crazytonyli commented Jul 11, 2023

Enabling weak_delegate swiftlint rule exposes a few places where delegate types are strongly referenced, which cause retain cycles.

diff --git a/.swiftlint.yml b/.swiftlint.yml
index 51ba0c206a..778047ace9 100644
--- a/.swiftlint.yml
+++ b/.swiftlint.yml
@@ -3,6 +3,10 @@ remote_timeout: 10.0
 
 opt_in_rules:
   - overridden_super_call
+  - weak_delegate
 
 overridden_super_call:
   severity: error
+
+weak_delegate:
+  severity: warning

The text was updated successfully, but these errors were encountered:

crazytonyli added the [Type] Bug label

crazytonyli self-assigned this

crazytonyli added the Memory Management label

This was referenced Jul 11, 2023

Declare a delegate property as a weak reference in WebKitViewController #21051

Merged

Change Jetpack connection delegates to weak references #21052

Merged

Change scanningDelegate to a weak reference #21053

Merged

Fix a retain cycle between RichTextView and its delegate #21062

Merged

Change SharingAccountViewController.delegate to be a weak reference #21063

Merged

Change a few delegate properties in Signup to be weak references #21064

Merged

Fix retain cycles in Site Creation #21066

Merged

Enable the weak_delegate SwiftLint rule #21068

Merged

crazytonyli closed this as completed in #21068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment