Support Django 4 #2801
Merged
Support Django 4 #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
in-progress
future-is-now
ivarnakken
force-pushed
the
django-4
branch
6 times, most recently
from
e34f744 to
4359835
Compare
ivarnakken
added
review-needed
ivarnakken
force-pushed
the
django-4
branch
5 times, most recently
from
64a1827 to
44257e0
Compare
ivarnakken
requested review from
LudvigHz,
SmithPeder,
eikhr,
erlingfn,
norbye and
theodorsm
erlingfn
reviewed
Jul 26, 2022
ivarnakken
added
do-not-merge/WIP
LudvigHz
reviewed
Jul 30, 2022
@erlingfn. The auth problems are fixed in webkom/lego-webapp#2924 |
|
From this related Stack Overflow question I'm suspecting that I recommend running Drone locally for a better traceback of the error: EDIT: Issue is resolved |
ivarnakken
removed
do-not-merge/WIP
ivarnakken
force-pushed
the
django-4
branch
5 times, most recently
from
6f07760 to
f0353b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
=======================================
Coverage 78.93% 78.93%
=======================================
Files 319 319
Lines 10709 10711 +2
=======================================
+ Hits 8453 8455 +2
Misses 2256 2256
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ivarnakken
added
dependencies
ivarnakken
added a commit
to webkom/lego-webapp
that referenced
this pull request
Aug 15, 2022
`drf-jwt` requires Bearer, instead of `djangorestframework-jwt`'s JWT scheme. This is related to webkom/lego#2801
|
I've done some extensive testing with this in staging, and everything seems to work as intended ™️. Would appreciate if others had a go with is as well ❤️ |
The Python standard library’s zoneinfo is now the default timezone implementation in Django: https://docs.djangoproject.com/en/4.0/releases/4.0/#zoneinfo-default-timezone-implementation
drf-jwt is an "updated" fork of djangorestframework-jwt, and give support for Django 4. Recommended by the author of djangorestframework-jwt: jpadilla/django-rest-framework-jwt#484
url() was deprecated in Django 3, and removed in Django 4.
As well as django-push-notifications to v3.0.0, in order to support Django 4.
E.g. 'coverage' and 'debug-toolbar' was missing when running `missing-migrations` through tox.
Required by Django
These were causing `missing_migrations` to fail.
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future is now
I've migrated what seems to be necessary in order to support Django 4. But, the new version brings a bunch of new interesting features that I would like to have a closer look at (potentially in a new PR). Nevertheless, this should be "ready" to review.
djangorestframework-jwtis replaced withdrf-jwt, which is simply an "updated" fork. However, I thinkdjangorestframework-simplejwthas some cool features (and the author ofdjangorestframework-jwtagrees), so I naturally begun to migrate to it but realized in the midst that it was kinda out of scope of what I'm trying to achieve with this PR, sodrf-jwtwill have to do for now - but will be replaced soon! Also, it's nice to diversify breaking changes into multiple PRs to minimize risk 😅