Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTTP auth scheme from JWT to Bearer #2924

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Aug 2, 2022

This is related to webkom/lego#2801.

drf-jwt requires Bearer, instead of djangorestframework-jwt's JWT scheme.

I've spent the last week contemplating and trying to figure out why the JWT auth was not behaving correctly ...... 😣 Check your header schemes kids

This must be merged together with webkom/lego#2801.

@ivarnakken ivarnakken added review-needed Pull requests that need review small-fix Pull requests that fix something small do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged labels Aug 2, 2022
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Aug 3, 2022
`drf-jwt` requires Bearer, instead of `djangorestframework-jwt`'s JWT scheme. This is related to webkom/lego#2801
@ivarnakken ivarnakken added ready-to-merge Pull requests that have been approved and are ready to be merged and removed do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged labels Aug 21, 2022
@ivarnakken ivarnakken merged commit afcd3e7 into master Aug 21, 2022
@ivarnakken ivarnakken deleted the drf-jwt-support branch August 21, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged small-fix Pull requests that fix something small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants