Fix all deprecated stuff #2805
Merged
Fix all deprecated stuff #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertEquals() has been deprecated for a long time, and raised DeprecationsWarnings. Also changed one assertNotEquals(). See https://docs.python.org/2/library/unittest.html#deprecated-aliases
Due to migration notice with django-filter. See: https://django-filter.readthedocs.io/en/main/guide/migration.html
The ViewSets were not compatible with schema generation. django-filter raised UserWarnings. See carltongibson/django-filter#966
'report' field is a `ContentField`, and is thus sanitized and then parsed through BeautifulSoup. BeautifulSoup would then raise warnings.
`@coroutine` decorator has been deprecated since Python 3.8.
ivarnakken
added
testing-needed
ivarnakken
requested review from
erlingfn,
eikhr,
norbye,
SmithPeder and
LudvigHz
LudvigHz
approved these changes
Jul 30, 2022
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bunch of super annoying deprecated stuff laying around, which would all raise a myriad of warnings when running tests. This fixes all of them:
Use assertEqual() instead of assertEquals()
ViewSet.filter_class attribute renamed filterset_class
Resolve incompatible ViewSets
Change markup in meeting fixtures to html
Replace @coroutine decorator with async/await
From this
To this 😍
The one small error left will be fixed in #2801