Extend version regex for RabbitMQ 3.8 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeinthehole
changed the title
wyardley
reviewed
Oct 10, 2019
Because, in RabbitMQ 3.8.0, the default output of `rabbitmqctl -q status` has changed; it no longer formats output using Erlang's property list format. When making a version check, we also verify the version has been extracted ok.
codeinthehole
force-pushed
the
fix-version-regex
branch
from
849a53c to
424155a
Compare
|
@wyardley Good point. Have fixed the tests and force-pushed back up. |
|
@codeinthehole thanks for the PR. Can you add an acceptance test that verifies this works? |
|
@bastelfreak unless they’ve been reworked, I think the acceptance tests still are only using the old version of RMQ and erlang? I can double check, but if so, it’s actually a pretty non-trivial task to add. |
|
ah, right. |
|
Maybe an additional unit test would have been good though? |
Closed
This was referenced Dec 2, 2019
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Jul 31, 2022
- Update existing tests to include the leading spaces and some additional formatting - Add new test case for the newer format included in `rabbitmqctl -q status` that's included in RabbitMQ >= v3.8.x, originally fixed in voxpupuli#814 See discussion in voxpupuli#872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where the output from
rabbitmqctl -q statusisn't printed as an Erlangproperty list.
Without this change, you get a crash with error: