-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests for rabbitmqctl version parsing #911
Merged
wyardley
merged 1 commit into
voxpupuli:master
from
wyardley:wyardley/test_version_regex
Aug 1, 2022
Merged
Update tests for rabbitmqctl version parsing #911
wyardley
merged 1 commit into
voxpupuli:master
from
wyardley:wyardley/test_version_regex
Aug 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new style output (newer versions)
3.7.x
|
- Update existing tests to include the leading spaces and some additional formatting - Add new test case for the newer format included in `rabbitmqctl -q status` that's included in RabbitMQ >= v3.8.x, originally fixed in voxpupuli#814 See discussion in voxpupuli#872
wyardley
force-pushed
the
wyardley/test_version_regex
branch
from
July 31, 2022 23:31
cdeda37
to
d8e1013
Compare
wyardley
commented
Aug 1, 2022
@@ -13,18 +13,23 @@ | |||
end | |||
|
|||
it 'gets the RabbitMQ version' do | |||
provider_class.expects(:rabbitmqctl).with('-q', 'status').returns '{rabbit,"RabbitMQ","3.1.5"}' | |||
expect(provider_class.rabbitmq_version).to eq('3.1.5') | |||
provider_class.expects(:rabbitmqctl).with('-q', 'status').returns ' [{rabbit,"RabbitMQ","3.7.28"},' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note - I don't think the format has changed here between 3.1 and 3.7; just thought it was maybe a good idea to make the string a little more realistic (though it's still not multiline).
bastelfreak
approved these changes
Aug 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
rabbitmqctl -q status
that's included in RabbitMQ >= v3.8.x, originally fixed in Extend version regex for RabbitMQ 3.8 #814See discussion in #872
That said, based on this, I believe the version parsing logic should function with >=3.8.x
This Pull Request (PR) fixes the following issues