Fix no returning rabbitmq_version and add default version?

[justintime4tea]

Signed-off-by: Justin Gross [email protected]

Pull Request (PR) description

I'm installing RabbitMQ 3.8.1 using rabbitmq module params as such:

management_enable          => true
package_name                    => rabbitmq-server-3.8.1
service_name                      => rabbitmq-server
use_config_file_for_plugins => true

I attempt to add user:

 rabbitmq_user { 'SOME_USER':
    password => 'SOME_PASS',
 }

A check is done to see what version rabbit is so to know which command line options to use when running the rabbitmq CLI (-q --no-table-headers, or just -q) to determine if the user already exists or not.

The self.rabbitmq_version function returns a version if @rabbitmq_version is declared.

When not declared however it apparently tries to declare it (not a ruby developer) but then afterwords never returns it so whomever has called it is receiving a NilClass? (at least the very first time? presumably, because it sets the @rabbitmq_server?)

The error produced is as such:
"Failed to apply catalog: undefined method `scan' for nil:NilClass" because rabbitmq_version never returns anything unless it is globally defined (@rabbitmq_version)

This error is referenced by this issue:
#817

This Pull Request (PR) fixes the following issues

[wyardley]

The module’s default behavior is to install 3.6.x, IIRC. I’m not sure if line 43 is necessary, but pretty sure this is the wrong behavior.

Do you get this issue with the most recent release, or with git master?

[wyardley]

Have you verified if #814 resolves this?

[KZachariassen]

Have you verified if #814 resolves this?

I have just tested this on Ubuntu 18.04 with puppet 3.8.1 and it solved my problem.

[wyardley]

I have just tested this on Ubuntu 18.04 with puppet 3.8.1 and it solved my problem.

“This” meaning the latest release? I.e., can we close this PR?

[KZachariassen]

I checked #814 directly - not the latest release, but I will do that first thing next week.