vdk-oracle: create oracle plugin #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
changed the title
This was
linked to
issues
Nov 22, 2023
Closed
DeltaMichael
force-pushed
the
feature/vdk-oracle
branch
from
4f9f352 to
e45db58
Compare
murphp15
reviewed
Nov 23, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Nov 23, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Show resolved
Hide resolved
DeltaMichael
commented
Nov 23, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Show resolved
Hide resolved
DeltaMichael
commented
Nov 23, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_connection.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_connection.py
Show resolved
Hide resolved
antoniivanov
approved these changes
Nov 24, 2023
DeltaMichael
force-pushed
the
feature/vdk-oracle
branch
from
e45db58 to
a210134
Compare
DeltaMichael
force-pushed
the
feature/vdk-oracle
branch
2 times, most recently
from
05040eb to
12520d9
Compare
Why? In order to support more use cases, vdk should support connecting and ingesting to an oracle database What? Add oracle plugin. Plugin supports simple queries, cli queries and ingestion. How was this tested? Local functional tests CI tests What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
feature/vdk-oracle
branch
from
12520d9 to
05bc117
Compare
murphp15
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In order to support more use cases, vdk should support connecting and ingesting to an oracle database
What?
Add oracle plugin. Plugin supports simple queries, cli queries and ingestion.
How was this tested?
Local functional tests, CI tests are part of a separate task
What kind of change is this?
Feature/non-breaking
Follow-up
Set up testcontainers for CI
Support type inference when ingesting
Support passing math.nAn and None for ingestion
Optimize batching of payload rows with different keysets
ORA-01002: fetch out of sequence error in _cache_tables when some rows fail to ingest
Further load testing
Investigate possible segfaults