Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-oracle: support passing math.nAn and None for ingestion #2930

Closed
DeltaMichael opened this issue Nov 22, 2023 · 0 comments
Closed

vdk-oracle: support passing math.nAn and None for ingestion #2930

DeltaMichael opened this issue Nov 22, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request initiative: VDK Oracle VDK Oracle support story Task for an Epic
Milestone

Comments

@DeltaMichael
Copy link
Contributor

DeltaMichael commented Nov 22, 2023

Overview

Passing math.nAn as part of an ingestion payload currently leads to ingestion errors. Passing None has not been tested. We should support passing both without any ingestion errors.

Example:

    payload2 = {"id": 6, "float_data": math.nan, "int_data": None}
    job_input.send_object_for_ingestion(
       payload=payload2, destination_table="test_table"
    )

Acceptance criteria

  1. We're able to pass math.nAn for ingestion
  2. We're able to pass None for ingestion
  3. There are tests covering this
@DeltaMichael DeltaMichael added the enhancement New feature or request label Nov 22, 2023
@DeltaMichael DeltaMichael added this to the VDK Oracle milestone Nov 22, 2023
@DeltaMichael DeltaMichael added the story Task for an Epic label Nov 22, 2023
DeltaMichael added a commit that referenced this issue Nov 24, 2023
## Why?
    
In order to support more use cases, vdk should support connecting and
ingesting to an oracle database
    
## What?
    
Add oracle plugin. Plugin supports simple queries, cli queries and
ingestion.
    
## How was this tested?
    
Local functional tests, CI tests are part of a separate task
    
## What kind of change is this?
    
Feature/non-breaking
    
## Follow-up

[Set up testcontainers for
CI](#2928)
[Support type inference when
ingesting](#2929)
[Support passing math.nAn and None for
ingestion](#2930)
[Optimize batching of payload rows with different
keysets](#2931)
[ORA-01002: fetch out of sequence error in _cache_tables when some rows
fail to
ingest](#2932)
[Further load
testing](#2933)
[Investigate possible
segfaults](#2934)

Signed-off-by: Dilyan Marinov <[email protected]>
Co-authored-by: Antoni Ivanov <[email protected]>
@DeltaMichael DeltaMichael self-assigned this Nov 27, 2023
@stefan-pulov stefan-pulov added the initiative: VDK Oracle VDK Oracle support label Mar 6, 2024
duyguHsnHsn added a commit that referenced this issue Mar 13, 2024
Solving: #2930

Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request initiative: VDK Oracle VDK Oracle support story Task for an Epic
Projects
None yet
Development

No branches or pull requests

3 participants