Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-oracle: support type inference when ingesting #2929

Closed
DeltaMichael opened this issue Nov 22, 2023 · 0 comments
Closed

vdk-oracle: support type inference when ingesting #2929

DeltaMichael opened this issue Nov 22, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request story Task for an Epic
Milestone

Comments

@DeltaMichael
Copy link
Contributor

DeltaMichael commented Nov 22, 2023

Overview

vdk-oracle should support type inference for ingesting string values into an existing table. For example, if we have a table such as

create table test_table (
    id number,
    int_data number,
    float_data float,
    bool_data number(1),
    primary key(id))

We should be able to pass an all-string payload where the types are inferred based on the existing table.

      payload = {
        "id": "1",
        "str_data": "string",
        "int_data": "12",
        "float_data": "1.2",
        "bool_data": "True",
    }

    job_input.send_object_for_ingestion(
        payload=local_payload, destination_table="test_table"
    )

Acceptance criteria

  1. The above scenario works with all available types (include timestamp and decimal)
  2. Test added for the above scenario
@DeltaMichael DeltaMichael added enhancement New feature or request story Task for an Epic labels Nov 22, 2023
@DeltaMichael DeltaMichael added this to the VDK Oracle milestone Nov 22, 2023
DeltaMichael added a commit that referenced this issue Nov 24, 2023
## Why?
    
In order to support more use cases, vdk should support connecting and
ingesting to an oracle database
    
## What?
    
Add oracle plugin. Plugin supports simple queries, cli queries and
ingestion.
    
## How was this tested?
    
Local functional tests, CI tests are part of a separate task
    
## What kind of change is this?
    
Feature/non-breaking
    
## Follow-up

[Set up testcontainers for
CI](#2928)
[Support type inference when
ingesting](#2929)
[Support passing math.nAn and None for
ingestion](#2930)
[Optimize batching of payload rows with different
keysets](#2931)
[ORA-01002: fetch out of sequence error in _cache_tables when some rows
fail to
ingest](#2932)
[Further load
testing](#2933)
[Investigate possible
segfaults](#2934)

Signed-off-by: Dilyan Marinov <[email protected]>
Co-authored-by: Antoni Ivanov <[email protected]>
@DeltaMichael DeltaMichael self-assigned this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request story Task for an Epic
Projects
None yet
Development

No branches or pull requests

1 participant