Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mapbox) use maplibre v3 instead of mapbox v1 #8550

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

chrisgervang
Copy link
Collaborator

For #8549

Note: maplibre v4 fails in our example due to a CORS issue, likely introduced with maplibre/maplibre-gl-js#3233. Needs more investigation.

Change List

  • use maplibre v3 instead of mapbox v1 in pure js example

@Pessimistress
Copy link
Collaborator

There is a strong pushback from the maplibre community against using the "mapbox" brand name with their library for branding and legal reasons. For example, they would like us to publish a new submodule @deck.gl/maplibre with MaplibreOverlay (maybe not at this time), and have get-started boiler-plate examples named "maplibre" (we probably should).

I know this example is named after the submodule, but better not mix the two unless we have to.

@chrisgervang
Copy link
Collaborator Author

I think that's a good direction too given they'll only diverge overtime. Maybe the new module could be added to 9.1 roadmap? In the meantime, I can rename folders and library references to maplibre.

@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

Changes unknown
when pulling 0a80577 on chr/pure-js-mapbox-to-maplibre-v9
into ** on master**.

@chrisgervang chrisgervang merged commit 6ce17f7 into master Feb 29, 2024
2 of 3 checks passed
@Pessimistress
Copy link
Collaborator

In the meantime, I can rename folders and library references to maplibre.

To be clear I did not advocate for "rename". We should not use the names "Mapbox" and "Maplibre" interchangeably. It's now equally confusing for the users of both libraries. We need separate doc pages and examples for both.

@chrisgervang chrisgervang deleted the chr/pure-js-mapbox-to-maplibre-v9 branch February 29, 2024 22:49
@HarelM
Copy link
Contributor

HarelM commented Mar 7, 2024

@chrisgervang which version 4 of maplibre did you use?
Is it possible that this issue was fixed in the latest version?
See the following issue:
maplibre/maplibre-gl-js#3680
In any case, if you are experiencing issues with maplibre v4 I would like to know as this version is new and there were a lot of refactoring there. I would be surprised if we introduced CORS issues, but anything is possible :-)

@chrisgervang
Copy link
Collaborator Author

Thanks @HarelM, I saw that issue too but it doesn't seem related. I've opened #8551 to figure this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants