-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mapbox) use maplibre v3 instead of mapbox v1 #8550
Conversation
Signed-off-by: Chris Gervang <[email protected]>
There is a strong pushback from the maplibre community against using the "mapbox" brand name with their library for branding and legal reasons. For example, they would like us to publish a new submodule I know this example is named after the submodule, but better not mix the two unless we have to. |
I think that's a good direction too given they'll only diverge overtime. Maybe the new module could be added to 9.1 roadmap? In the meantime, I can rename folders and library references to maplibre. |
Changes unknown |
Signed-off-by: Chris Gervang <[email protected]>
To be clear I did not advocate for "rename". We should not use the names "Mapbox" and "Maplibre" interchangeably. It's now equally confusing for the users of both libraries. We need separate doc pages and examples for both. |
@chrisgervang which version 4 of maplibre did you use? |
For #8549
Note: maplibre v4 fails in our example due to a CORS issue, likely introduced with maplibre/maplibre-gl-js#3233. Needs more investigation.
Change List