-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maplibre v4 raises a CORS error in our examples #8551
Comments
I'm noticing this in v3 as well actually. @alasarr @felixpalmer, is there something we need to configure in the Carto style or in how we use maplibre going forward? |
@chrisgervang that maplibre PR is pretty huge, could you elaborate as to why you think that PR introduces the issue? |
I'm actually seeing it in #8555 as well, which is using v3. It suggests this big PR isn't the cause. It's hard to believe we're the first to have this issue, but searching maplibre doesn't return a lot to do with CORS errors. |
I was able to get the tiles when using https://maplibre.org/maputnik/, which uses version 4 of maplibre, so I'm not sure maplibre is to blame here. |
The issue had been difficult to reproduce today... and then I remembered I might have had a VPN on. The CORS error consistently appears while on my VPN. For posterity, I disabled my VPN, disabled cacheing in DevTools, tested with I think that confirms a VPN can CORS errors (maybe that was common knowledge). |
What I failed to mention earlier is CORS wasn't the only issue I noticed.. I also noticed a rendering issue in Maplibre where tiles aren't rendering correctly - they "checkerboard" while navigating. I thought this was related to CORS, but now I've confirmed it's actually a regression in our interleaved rendering mode. interleaved.mp4I'll open up an issue for this with a repro. |
Might have been introduced with maplibre/maplibre-gl-js#3233, but need investigation.
Expected
Actual
The text was updated successfully, but these errors were encountered: