-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expected content of resolving merge-keep_profile.xml #1556
Fix expected content of resolving merge-keep_profile.xml #1556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galtm thanks for the correction! @david-waltermire-nist if this PR conflicts let's discuss - with luck we'll also be visiting these files again RSN.
eff9ce3
to
dd6486a
Compare
Hi @galtm, thanks for submitting yet another excellent PR. We had to rebase develop and that leads to the "This branch has conflicts that must be resolved" conflicts below. I can help you with that, please let me know if and when you need that help. Thanks. |
3eb51b8
to
89a3b2c
Compare
@aj-stein-nist : I resolved the merge conflicts. If anything doesn't look right to you, let me know. Thanks. |
fb85a27
to
6661368
Compare
89a3b2c
to
30cd14b
Compare
f8f187f
to
21abd43
Compare
Will rebase on rebased |
Based on the content of the catalog whose controls are being imported, the prop names should be "label" instead of "place" and the a1 statement paragraph should include <insert>. Also, remove a debugging message.
30cd14b
to
b7d9a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks AJ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before approval, I will want to create a cross-reference issue to include for an upcoming patch release to identify this fix. In the interim, I will approve it as the work continues to be solid.
Thanks again, @galtm, and I appreciate your patience.
Committer Notes
This pull request fixes one of the expected output files in the set of sample profiles. Based on the content of the catalog whose controls are being imported, the prop names should be "label" instead of "place" and the a1 statement paragraph should include
<insert>
.I also noticed a debugging message I had left in the XSLT profile resolver code inadvertently with #1321, so I'm removing that message.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.