Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected content of resolving merge-keep_profile.xml #1556

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

galtm
Copy link
Contributor

@galtm galtm commented Nov 22, 2022

Committer Notes

This pull request fixes one of the expected output files in the set of sample profiles. Based on the content of the catalog whose controls are being imported, the prop names should be "label" instead of "place" and the a1 statement paragraph should include <insert>.

I also noticed a debugging message I had left in the XSLT profile resolver code inadvertently with #1321, so I'm removing that message.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

wendellpiez
wendellpiez previously approved these changes Dec 7, 2022
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galtm thanks for the correction! @david-waltermire-nist if this PR conflicts let's discuss - with luck we'll also be visiting these files again RSN.

@aj-stein-nist
Copy link
Contributor

Hi @galtm, thanks for submitting yet another excellent PR. We had to rebase develop and that leads to the "This branch has conflicts that must be resolved" conflicts below. I can help you with that, please let me know if and when you need that help. Thanks.

@galtm
Copy link
Contributor Author

galtm commented Jan 13, 2023

@aj-stein-nist : I resolved the merge conflicts. If anything doesn't look right to you, let me know. Thanks.

@aj-stein-nist
Copy link
Contributor

Will rebase on rebased develop to include bad link correction in #1931 that is failing build (not meaningful changes of PR).

Based on the content of the catalog whose controls are being
imported, the prop names should be "label" instead of "place"
and the a1 statement paragraph should include <insert>.

Also, remove a debugging message.
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks AJ!

@aj-stein-nist aj-stein-nist changed the title Fix expected content of resolving merge-keep_profile.xml [DONOTMERGE] Fix expected content of resolving merge-keep_profile.xml Sep 27, 2023
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before approval, I will want to create a cross-reference issue to include for an upcoming patch release to identify this fix. In the interim, I will approve it as the work continues to be solid.

Thanks again, @galtm, and I appreciate your patience.

@aj-stein-nist aj-stein-nist changed the title [DONOTMERGE] Fix expected content of resolving merge-keep_profile.xml Fix expected content of resolving merge-keep_profile.xml Sep 28, 2023
@aj-stein-nist aj-stein-nist merged commit a97e083 into usnistgov:develop Sep 28, 2023
@galtm galtm deleted the profile-example-propname branch September 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile Resolution Issues relating to profile resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile resolver tests for control labels with merge/keep are incorrect
4 participants