Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile resolver tests for control labels with merge/keep are incorrect #1938

Closed
aj-stein-nist opened this issue Sep 28, 2023 · 0 comments · Fixed by #1556
Closed

Profile resolver tests for control labels with merge/keep are incorrect #1938

aj-stein-nist opened this issue Sep 28, 2023 · 0 comments · Fixed by #1556
Labels
bug Profile Resolution Issues relating to profile resolution. Scope: Tooling and APIs Issues targeted at development of tooling and APIs to support OSCAL content creation and use.
Milestone

Comments

@aj-stein-nist
Copy link
Contributor

Describe the bug

In the profile resolver's test suite, there are tests that use an example property (place) in place of a relevant property name that can be used to verify the XSLT reference implementation of the profile resolver processing those properties with the combine/keep strategy.

NOTE: This is a backported issue for a community contribution that had not yet been merged. This is to track the inclusion of this work for merge into the develop branch and prepare for an upcoming release.

Who is the bug affecting

Developers implementing profile resolution that intend to follow the specification and verify their implementation by following the reference implementation unit tests in this repository.

What is affected by this bug

Tooling & API

How do we replicate this issue

  1. Run the profile resolution tests.
  2. Observe the usage of misleading prop on test controls with name of place.

Expected behavior (i.e. solution)

  1. Control properties would have an applicable property name identified in documentation and constraints, primarily label that is often used with controls.

Other comments

No response

Revisions

No response

@aj-stein-nist aj-stein-nist added Scope: Tooling and APIs Issues targeted at development of tooling and APIs to support OSCAL content creation and use. Profile Resolution Issues relating to profile resolution. labels Sep 28, 2023
@aj-stein-nist aj-stein-nist linked a pull request Sep 28, 2023 that will close this issue
7 tasks
@aj-stein-nist aj-stein-nist added this to the Next milestone Sep 28, 2023
@aj-stein-nist aj-stein-nist moved this from Needs Triage to Needs Pruning in NIST OSCAL Work Board Sep 28, 2023
@aj-stein-nist aj-stein-nist moved this from Needs Pruning to Volunteer Needed in NIST OSCAL Work Board Sep 28, 2023
@aj-stein-nist aj-stein-nist moved this from Volunteer Needed to Reviewer Approved in NIST OSCAL Work Board Sep 28, 2023
@aj-stein-nist aj-stein-nist moved this from Reviewer Approved to Done in NIST OSCAL Work Board Sep 28, 2023
@aj-stein-nist aj-stein-nist modified the milestones: Next, Ready Now Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Profile Resolution Issues relating to profile resolution. Scope: Tooling and APIs Issues targeted at development of tooling and APIs to support OSCAL content creation and use.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant