Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore link check failures for xmllint man page #1931

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Sep 18, 2023

Committer Notes

Ignore linux.die.net man page mirror which seems to fail link update PR and other commits targeting develop and main. Closes #1926 for good (with a related but different failure).

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this Sep 18, 2023
@aj-stein-nist aj-stein-nist linked an issue Sep 18, 2023 that may be closed by this pull request
@aj-stein-nist aj-stein-nist force-pushed the 1926-markdown-link-check-ignore-linux-die-net branch from 8398d22 to 3d127ae Compare September 18, 2023 02:40
@aj-stein-nist aj-stein-nist force-pushed the 1926-markdown-link-check-ignore-linux-die-net branch 2 times, most recently from 2f76a45 to ec4da05 Compare September 18, 2023 02:51
@aj-stein-nist
Copy link
Contributor Author

It appears my merge of #1929 was probably best intended for the target branch of main, not develop. (The periodic GHA job actually targets main by default, I am not sure why that escaped my memory whilst reviewing and approving.)🤦 I am not sure the very best course of action is to cherry-pick that commit onto here and cause a potential conflict, or better is to revert off of develop, re-merge that same change onto main, add this, and then rebase develop off the updated main. TBD for tomorrow's standup.

@aj-stein-nist aj-stein-nist marked this pull request as ready for review September 26, 2023 15:34
@aj-stein-nist aj-stein-nist requested a review from a team September 26, 2023 15:34
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple small fix. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled Check of Markdown Documents Found Bad Hyperlinks
2 participants