Add E2E testing framework MVP #1368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
force-pushed
the
cmichi-add-e2e-testing-mvp
branch
from
1f30d9c to
6bdfa9a
Compare
* pin gha versions * pin gha version * fix hash
* Add `version` field to `InkProject` * Use `InkProject` directly in metadata codegen * Remove old metadata versions from version enum These versions can't be constructed using this version of the crate anyways, so it doesn't really make sense to keep them. * Manually implement `Default` We should change to using the derive macros once our CI's nightly compiler version gets updated. * Add metadata `V4` version option * Use my branch of `cargo-contract` in CI * Remove deprecated `V3` metadata We're never able to construct this variant with this crate anymore, so it doesn't make sense to keep it.
* Rename `RELEASES` to `CHANGELOG` We're following the [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) conventions anyways, so the name makes more sense. * Reduce header sizes by one level
* Move linting into ink repo * Fix CI * Apply suggestions from code review Co-authored-by: Alexander Samusev <[email protected]> * Update .gitlab-ci.yml Co-authored-by: Alexander Samusev <[email protected]> * Update linting/Cargo.toml Co-authored-by: Hernando Castano <[email protected]> * Update linting/Cargo.toml Co-authored-by: Hernando Castano <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Hernando Castano <[email protected]>
* Add release notes for `v4.0.0-alpha.1` * Mention breaking changes in changelog * Bump version to `4.0.0-alpha.1` * Fix header levels after merge * Fix some formatting * Add some notes about the breaking changes * Add links to PRs * Add note about linting move * Bump `ink_linting` crate to `4.0.0-alpha.1` * Remove `nightly` usage from delegator build script * Use dashes instead of minus signs Co-authored-by: Michael Müller <[email protected]> * Beef up description of linter PR Co-authored-by: Michael Müller <[email protected]> * Move compatibility section to top of release notes * Explicitly use `stable` channel Our Docker images still default to `nightly` * Build contracts with `stable` toolchain * Install `rust-src` component before building examples * Run the rest of the CI stages again Co-authored-by: Michael Müller <[email protected]>
* Mention that a new `cargo-contract` release needs to be used * Update CI to use released `cargo-contract` version
* Remove `version` from dev-dependencies Looks like Cargo decides to either use a local or published package depending on the context (i.e `path` vs. `version`) Since we never publish `dev-dependencies` we can stick to always using a local version (`path`). Cargo book reference: - https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations * Sort `dev-dependencies` alphabetically
* Update the release checklist This simplies the release checklist a bit by using both `cargo-unleash` and `cargo-release`. `cargo-release` has been way more reliable for publishing the ink! workspace than `cargo-unleash`, but we still use `cargo-unleash` to clean up our `dev-dependencies`. In the future it would be cool to automate more of the release process, such as tag creation and publishing, through `cargo-release`. * Remove steps related to `dev-dependencies` With #1367 these shouldn't be required anymore. * Add missing punctuation Co-authored-by: Michael Müller <[email protected]> Co-authored-by: Michael Müller <[email protected]>
…k into cmichi-add-e2e-testing-mvp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP for #1234.
Contains only E2E tests for
examples/contract-transfer. Once we've nailed down the API I'll migrate the rest in follow-up PRs. The best way to look at this PR is, I think, to look at the tests for that example.I've annotated a couple of
TODO(#xxx)comments ‒ I'll create the issues + add the number before merging, I'm just waiting for approvals beforehand.