Update the release checklist #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplies the release checklist a bit by using both `cargo-unleash` and `cargo-release`. `cargo-release` has been way more reliable for publishing the ink! workspace than `cargo-unleash`, but we still use `cargo-unleash` to clean up our `dev-dependencies`. In the future it would be cool to automate more of the release process, such as tag creation and publishing, through `cargo-release`.
With #1367 these shouldn't be required anymore.
ascjones
reviewed
Aug 26, 2022
| - We cannot release with `dev-dependencies` due to some cyclic dependencies that | ||
| exist. | ||
| 1. Do a dry run with `cargo release [level] -v --no-tag --no-push --allow-dirty` | ||
| 1. Do a dry run with `cargo release [level] -v --no-tag --no-push` |
There was a problem hiding this comment.
What values can [level] have?
There was a problem hiding this comment.
You can find them as part of the cargo-release documentation. I don't think it makes sense to have them here, but if you think it would be helpful I don't mind adding them
Co-authored-by: Michael Müller <[email protected]>
cmichi
added a commit
that referenced
this pull request
Aug 31, 2022
* Update the release checklist This simplies the release checklist a bit by using both `cargo-unleash` and `cargo-release`. `cargo-release` has been way more reliable for publishing the ink! workspace than `cargo-unleash`, but we still use `cargo-unleash` to clean up our `dev-dependencies`. In the future it would be cool to automate more of the release process, such as tag creation and publishing, through `cargo-release`. * Remove steps related to `dev-dependencies` With #1367 these shouldn't be required anymore. * Add missing punctuation Co-authored-by: Michael Müller <[email protected]> Co-authored-by: Michael Müller <[email protected]>
xermicus
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Update the release checklist This simplies the release checklist a bit by using both `cargo-unleash` and `cargo-release`. `cargo-release` has been way more reliable for publishing the ink! workspace than `cargo-unleash`, but we still use `cargo-unleash` to clean up our `dev-dependencies`. In the future it would be cool to automate more of the release process, such as tag creation and publishing, through `cargo-release`. * Remove steps related to `dev-dependencies` With #1367 these shouldn't be required anymore. * Add missing punctuation Co-authored-by: Michael Müller <[email protected]> Co-authored-by: Michael Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplies the release checklist a bit by using both
cargo-unleashand
cargo-release.cargo-releasehas been way more reliable forpublishing the ink! workspace than
cargo-unleash, but we still usecargo-unleashto clean up ourdev-dependencies.In the future it would be cool to automate more of the release process,
such as tag creation and publishing, through
cargo-release.