Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arborist UI integration #592

Merged
merged 13 commits into from
Oct 14, 2019
Merged

Arborist UI integration #592

merged 13 commits into from
Oct 14, 2019

Conversation

vpsx
Copy link
Contributor

@vpsx vpsx commented Oct 10, 2019

arborist ui integration--change UI based on user's authz.
see spec here

Needs Arborist's GET /auth/mapping endpoint to be exposed via revproxy:
uc-cdis/arborist#110
uc-cdis/cloud-automation#1006

To use this feature, add "useArboristUI": true in gitops.json

New Features

  • get auth mapping from arborist if useArboristUI true in config
  • per-project submit data buttons change verbiage based on user's authz
  • top bar submit data button changes verbiage based on user's authz
  • toggle visibility of recent submissions table based on user's authz
  • toggle visibility of map my files card based on user's authz
  • toggle form submission and upload file button visibility on project page based on user's authz
  • toggle node browser delete button visibility based on user's authz

Deployment changes

  • if deployed with "useArboristUI": true, needs Arborist's GET /auth/mapping endpoint to be exposed via revproxy. (useArboristUI false by default)

@vpsx vpsx force-pushed the feat/auth-mapping branch 2 times, most recently from 292e2f5 to 513210f Compare October 10, 2019 19:17
@vpsx vpsx changed the title wip Arborist UI integration Oct 10, 2019
@vpsx vpsx force-pushed the feat/auth-mapping branch 2 times, most recently from 5e1d0e6 to 163e412 Compare October 11, 2019 16:39
@paulineribeyre
Copy link
Contributor

could you add a "deployment changes" section - if deployed with "useArboristUI": true, Needs Arborist's GET /auth/mapping endpoint to be exposed via revproxy

@vpsx vpsx force-pushed the feat/auth-mapping branch from 163e412 to 1a49ebe Compare October 11, 2019 17:57
Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice! a few comments

Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! thank you 👍

@vpsx vpsx merged commit d6ad331 into master Oct 14, 2019
@vpsx vpsx deleted the feat/auth-mapping branch October 15, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants