feat(authz-mapping): expose authz mapping endpoint #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpsx
force-pushed
the
feat/authz-mapping
branch
from
804fc7d to
4e3db19
Compare
vpsx
force-pushed
the
feat/authz-mapping
branch
from
4e3db19 to
925dfa2
Compare
frickjack
reviewed
Oct 8, 2019
|
|
||
| set $upstream http://${arborist_release_name}-service.$namespace.svc.cluster.local; | ||
|
|
||
| proxy_pass $upstream/auth/mapping?username=$arg_username; |
There was a problem hiding this comment.
the username query string for the endpoint--if I leave it out then nginx seems to not pass the query args to arborist
This was referenced Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related Arborist PR here uc-cdis/arborist#110
related Windmill PR here uc-cdis/data-portal#592
New Features
expose arborist's /auth/mapping endpoint (to GET requests only, and without passing the username query param)