Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybase: don't wait for wsgi.sock #1438

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Conversation

paulineribeyre
Copy link
Contributor

The block that waits for wsgi.sock to appear is before run uwsgi --ini /etc/uwsgi/uwsgi.ini so it makes us wait 20 seconds for something that will not happen (since the app hasn't started yet). Remove it doesn't seem to cause issues

Improvements

  • Base python 2 and 3 images: don't wait for wsgi.sock to appear, speed up app start up

Copy link
Contributor

@frickjack frickjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@paulineribeyre paulineribeyre merged commit d303f9e into master Oct 23, 2020
@paulineribeyre paulineribeyre deleted the paulineribeyre-patch-1 branch October 23, 2020 22:03
jacquayj added a commit to bioteam/cloud-automation that referenced this pull request Nov 10, 2020
* commit '59bf7fdd8bc1a497b2347eb3610612b97ded3023': (234 commits)
  Chore/config env upgrade pip (uc-cdis#1448)
  Chore/remove pylib2 (uc-cdis#1447)
  add new dependency (uc-cdis#1446)
  Chore/wts fail fast (uc-cdis#1445)
  feat(sftp-server): Added terraform to create sftp server (uc-cdis#1437)
  Feat/mariner storage (uc-cdis#1442)
  chore(useryaml): only in usersync (uc-cdis#1440)
  Whitelist opportunityinsights.org (uc-cdis#1441)
  Fix/tform eks (uc-cdis#1439)
  Pybase: don't wait for wsgi.sock (uc-cdis#1438)
  chore(dashboard/open-links): new dash app (uc-cdis#1436)
  Chore/update calico 1.7 (uc-cdis#1427)
  fix(jenkinx-pv-size): Updated the size of the persistent volume to match manual size increase (uc-cdis#1417)
  Fix/configmaps del (uc-cdis#1434)
  Chore/vpn signed url (uc-cdis#1433)
  feat(access-roll): Added access-backend to kube-roll-all (uc-cdis#1431)
  (PXP-6861): configure Metadata Service creds in kube-setup-ssjdispatcher (uc-cdis#1428)
  Chore/tform  custom (uc-cdis#1426)
  Update maintenance.md (uc-cdis#1425)
  fix(qa): Define submission order for gentestdata (uc-cdis#1424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants