Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/configmaps del #1434

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Fix/configmaps del #1434

merged 2 commits into from
Oct 16, 2020

Conversation

mfshao
Copy link
Contributor

@mfshao mfshao commented Oct 15, 2020 •
edited
Loading

Update configmap deletion logic to grab existing configmap names from env rather than from manifest file

Improvements

  • Update configmap deletion logic to grab existing configmap names from env rather than from manifest file

@mfshao mfshao marked this pull request as ready for review October 16, 2020 14:42
jawadqur
jawadqur approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@jawadqur jawadqur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfshao mfshao merged commit c4d6711 into master Oct 16, 2020
@mfshao mfshao deleted the fix/configmaps-del branch October 16, 2020 15:14
jacquayj added a commit to bioteam/cloud-automation that referenced this pull request Nov 10, 2020
@jacquayj
Merge commit '59bf7fdd8bc1a497b2347eb3610612b97ded3023'
5a86104 
* commit '59bf7fdd8bc1a497b2347eb3610612b97ded3023': (234 commits)
  Chore/config env upgrade pip (uc-cdis#1448)
  Chore/remove pylib2 (uc-cdis#1447)
  add new dependency (uc-cdis#1446)
  Chore/wts fail fast (uc-cdis#1445)
  feat(sftp-server): Added terraform to create sftp server (uc-cdis#1437)
  Feat/mariner storage (uc-cdis#1442)
  chore(useryaml): only in usersync (uc-cdis#1440)
  Whitelist opportunityinsights.org (uc-cdis#1441)
  Fix/tform eks (uc-cdis#1439)
  Pybase: don't wait for wsgi.sock (uc-cdis#1438)
  chore(dashboard/open-links): new dash app (uc-cdis#1436)
  Chore/update calico 1.7 (uc-cdis#1427)
  fix(jenkinx-pv-size): Updated the size of the persistent volume to match manual size increase (uc-cdis#1417)
  Fix/configmaps del (uc-cdis#1434)
  Chore/vpn signed url (uc-cdis#1433)
  feat(access-roll): Added access-backend to kube-roll-all (uc-cdis#1431)
  (PXP-6861): configure Metadata Service creds in kube-setup-ssjdispatcher (uc-cdis#1428)
  Chore/tform  custom (uc-cdis#1426)
  Update maintenance.md (uc-cdis#1425)
  fix(qa): Define submission order for gentestdata (uc-cdis#1424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawadqur jawadqur jawadqur approved these changes

Assignees
No one assigned
Labels
test-portal-homepageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfshao @jawadqur