fix(qa): Define submission order for gentestdata #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frickjack
reviewed
Oct 8, 2020
| @@ -83,6 +83,8 @@ spec: | |||
| GEN3_TEST_PROJECT|-value: "test"-| | |||
| - name: MAX_EXAMPLES | |||
| GEN3_MAX_EXAMPLES|-value: "10"-| | |||
| - name: SUBMISSION_ORDER | |||
| GEN3_MAX_EXAMPLES|-value: "submitted_unaligned_reads"-| | |||
There was a problem hiding this comment.
you probably want GEN3_SUBMISSION_ORDER here to allow command-line override?
There was a problem hiding this comment.
😮 Oh, how does that work?
You have some cool mechanism that seamlessly acts upon GEN3_ prefixed parameters? (that's cool)
Let me push a commit...
There was a problem hiding this comment.
also - update the documentation comment at the top ...
frickjack
approved these changes
Oct 8, 2020
jacquayj
added a commit
to bioteam/cloud-automation
that referenced
this pull request
Nov 10, 2020
* commit '59bf7fdd8bc1a497b2347eb3610612b97ded3023': (234 commits) Chore/config env upgrade pip (uc-cdis#1448) Chore/remove pylib2 (uc-cdis#1447) add new dependency (uc-cdis#1446) Chore/wts fail fast (uc-cdis#1445) feat(sftp-server): Added terraform to create sftp server (uc-cdis#1437) Feat/mariner storage (uc-cdis#1442) chore(useryaml): only in usersync (uc-cdis#1440) Whitelist opportunityinsights.org (uc-cdis#1441) Fix/tform eks (uc-cdis#1439) Pybase: don't wait for wsgi.sock (uc-cdis#1438) chore(dashboard/open-links): new dash app (uc-cdis#1436) Chore/update calico 1.7 (uc-cdis#1427) fix(jenkinx-pv-size): Updated the size of the persistent volume to match manual size increase (uc-cdis#1417) Fix/configmaps del (uc-cdis#1434) Chore/vpn signed url (uc-cdis#1433) feat(access-roll): Added access-backend to kube-roll-all (uc-cdis#1431) (PXP-6861): configure Metadata Service creds in kube-setup-ssjdispatcher (uc-cdis#1428) Chore/tform custom (uc-cdis#1426) Update maintenance.md (uc-cdis#1425) fix(qa): Define submission order for gentestdata (uc-cdis#1424) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding submission order command to existing
gentestdatak8s job's sequence of commands.