Update shared memory bound checking for infer requests #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
reviewed
Apr 9, 2024
|
Could you update the PR description to better reflect the changes? |
jbkyang-nvi
force-pushed
the
kyang-validate-shm-byte-size
branch
from
c19ea39 to
9f29920
Compare
Tabrizian
reviewed
Apr 10, 2024
src/c++/perf_analyzer/client_backend/triton_c_api/shared_memory_manager.h
Outdated
Show resolved
Hide resolved
src/c++/perf_analyzer/client_backend/triton_c_api/shared_memory_manager.h
Outdated
Show resolved
Hide resolved
src/c++/perf_analyzer/client_backend/triton_c_api/shared_memory_manager.cc
Show resolved
Hide resolved
Co-authored-by: Iman Tabrizian <[email protected]>
Co-authored-by: Iman Tabrizian <[email protected]>
…rence-server/client into kyang-validate-shm-byte-size
jbkyang-nvi
changed the title
Tabrizian
approved these changes
Apr 11, 2024
jbkyang-nvi
added a commit
to triton-inference-server/server
that referenced
this pull request
Apr 12, 2024
…nds (#7083) Validate that memory offset and byte size requested is not out of bounds of registered memory. Previously in #6914 we checked out of bounds offset for shared memory requests. This PR also adds more testing to verify the block of memory is in fact in bounds. Client change: triton-inference-server/client#565
jbkyang-nvi
added a commit
to triton-inference-server/server
that referenced
this pull request
Apr 12, 2024
…nds (#7083) Validate that memory offset and byte size requested is not out of bounds of registered memory. Previously in #6914 we checked out of bounds offset for shared memory requests. This PR also adds more testing to verify the block of memory is in fact in bounds. Client change: triton-inference-server/client#565
jbkyang-nvi
added a commit
that referenced
this pull request
Apr 12, 2024
This was referenced Apr 12, 2024
mc-nv
pushed a commit
that referenced
this pull request
Apr 12, 2024
mc-nv
pushed a commit
to triton-inference-server/server
that referenced
this pull request
Apr 12, 2024
…nds (#7083) (#7111) Validate that memory offset and byte size requested is not out of bounds of registered memory. Previously in #6914 we checked out of bounds offset for shared memory requests. This PR also adds more testing to verify the block of memory is in fact in bounds. Client change: triton-inference-server/client#565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server PR: triton-inference-server/server#7083