Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared memory bound checking for infer requests #565

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Update shared memory bound checking for infer requests #565

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f31ffe9
update according to server changes
jbkyang-nvi Apr 9, 2024
9f29920
update get memory info
jbkyang-nvi Apr 9, 2024
999ec3e
Merge branch 'main' into kyang-validate-shm-byte-size
jbkyang-nvi Apr 10, 2024
1c9d3a5
Update documentation suggestion
jbkyang-nvi Apr 10, 2024
70ffb76
Update documentation suggestion
jbkyang-nvi Apr 10, 2024
92983fb
Include actual server changes
jbkyang-nvi Apr 10, 2024
d8559ae
Merge branch 'kyang-validate-shm-byte-size' of github.com:triton-infe…
jbkyang-nvi Apr 10, 2024
7305596
Merge branch 'main' into kyang-validate-shm-byte-size
jbkyang-nvi Apr 10, 2024
1c37525
Merge branch 'main' into kyang-validate-shm-byte-size
jbkyang-nvi Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/c++/perf_analyzer/client_backend/triton_c_api/triton_loader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,8 @@ TritonLoader::Infer(
TRITONSERVER_MemoryType memory_type;
int64_t memory_type_id;
RETURN_IF_ERROR(shm_manager_->GetMemoryInfo(
shm_name, offset, &buf, &memory_type, &memory_type_id));
shm_name, offset, shm_byte_size, &buf, &memory_type,
jbkyang-nvi marked this conversation as resolved.
Show resolved Hide resolved
&memory_type_id));

alloc_payload.output_map_.emplace(
std::piecewise_construct, std::forward_as_tuple(output->Name()),
Expand Down Expand Up @@ -1149,7 +1150,8 @@ TritonLoader::AddInputs(
TRITONSERVER_MemoryType memory_type;
int64_t memory_type_id;
RETURN_IF_ERROR(shm_manager_->GetMemoryInfo(
shm_name, offset, &buf, &memory_type, &memory_type_id));
shm_name, offset, shm_byte_size, &buf, &memory_type,
&memory_type_id));
RETURN_IF_TRITONSERVER_ERROR(
inference_request_append_input_data_fn_(
irequest, input_name, buf, byte_size,
Expand Down
Loading