Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the memory requested for the infer request is not out of bounds #7111

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jbkyang-nvi
Copy link
Contributor

@jbkyang-nvi jbkyang-nvi commented Apr 12, 2024

Validate that memory offset and byte size requested is not out of bounds
of registered memory.
Previously in #6914 we checked out of bounds offset for shared memory requests.
This PR also adds more testing to verify the block of memory is in fact in bounds.
Client change: triton-inference-server/client#565
Cherry pick of: #7083

…nds (#7083)

Validate that memory offset and byte size requested is not out of bounds 
of registered memory. 
Previously in #6914 we checked out of bounds offset for shared memory
requests. This PR also adds more testing to verify the block of memory 
is in fact in bounds.
Client change: triton-inference-server/client#565
@jbkyang-nvi jbkyang-nvi requested review from Tabrizian and mc-nv April 12, 2024 19:00
@mc-nv
Copy link
Contributor

mc-nv commented Apr 12, 2024

@jbkyang-nvi may I know why commit in this PR doesn't match mentioned one #6914
60071e1

@jbkyang-nvi
Copy link
Contributor Author

@jbkyang-nvi may I know why commit in this PR doesn't match mentioned one #6914 60071e1

This is a PR doing a different thing. @mc-nv

@mc-nv mc-nv merged commit 5ff6935 into r24.04 Apr 12, 2024
3 checks passed
@mc-nv mc-nv deleted the kyang-validate-shm-byte-size-r24.04 branch April 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants