(DO NOT MERGE) Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled) #5314

mhoemmen · 2019-06-04T20:55:06Z

@trilinos/tpetra

Description

Make TpetraCore build with deprecated code disabled (Tpetra_ENABLE_DEPRECATED_CODE=OFF and KOKKOS_ENABLE_DEPRECATED_CODE=OFF). Some tests still fail in that case, but at least we can get the build working so that users can try the deprecation.

Related Issues

@trilinos/tpetra

@trilinos/tpetra I haven't tested downstream code yet.

@trilinos/tpetra

trilinos-autotester · 2019-06-04T21:16:25Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2019-06-04T21:18:23Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 3743
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 3558
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Build Num: 2004
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Build Num: 1779
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Build Num: 1408
Status: STARTED

Jenkins Parameters

Parameter Name	Value
JENKINS_JOB_TYPE	Experimental
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)

Pull Request Author: mhoemmen

mhoemmen · 2019-06-04T21:18:53Z

Thanks @csiefer2 ! Let me see what @tjfulle and @kddevin have in mind before merging.

tjfulle · 2019-06-04T21:27:05Z

@kddevin and I have been working on a branch doing very similar code modifications. @kddevin has worked on a lot of non Tpetra tests and I had fixed several Tpetra issues. We put it on hold for a few days until I could finish up #5164. Now that #5268 is merged, I had planned to continue on fixing broken tests with deprecated code off. This branch will surely conflict with what we are doing. If it is a hot-fix for another project, go ahead and merge. If it can wait a day or two so I can get a pulse on where mine and @kddevin's efforts are at, that would be helpful.

mhoemmen · 2019-06-04T21:33:35Z

@tjfulle It can wait. I just wanted to see how far I could get.

trilinos-autotester · 2019-06-05T00:57:53Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 3743
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 3558
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Build Num: 2004
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Build Num: 1779
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Build Num: 1408
Status: PASSED

Jenkins Parameters

Parameter Name	Value
JENKINS_JOB_TYPE	Experimental
PULLREQUESTNUM	5314
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	Fix-5117
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`a8acad2`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`26b50ae`

CDash Test Results for PR# 5314.

trilinos-autotester · 2019-06-05T00:58:11Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

trilinos-autotester · 2019-06-05T00:58:18Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

kddevin · 2019-06-05T05:27:14Z

Some of this work has already been done by me in tjfulle's fork, branch issue-5065, but not yet merged to Trilinos develop.
Please do not merge this branch until my work can be merged.

kddevin

Please wait until tfjulle fork, branch issue-5065, is merged.

…tall (trilinos/Trilinos#5314) This was needed because the Trilinos Gtest package now has a mode where it will not install its library (but allows tests in downstream packages to use it). I changed the variable ${PACKAGE_NAME}_HAS_NATIVE_LIBRARIES to ${PACKAGE_NAME}_HAS_NATIVE_LIBRARIES_TO_INSTALL since that is how it is actually used.

…/Trilinos#5314)

…bs to install (trilinos#5314) This was needed because the Trilinos Gtest package now has a mode where it will not install its library (but allows tests in downstream packages to use it). I changed the variable ${PACKAGE_NAME}_HAS_NATIVE_LIBRARIES to ${PACKAGE_NAME}_HAS_NATIVE_LIBRARIES_TO_INSTALL since that is how it is actually used.

Build/Test Cases Summary Enabled Packages: Enabled all Packages 0) MPI_DEBUG => passed: passed=361,notpassed=0 (1.00 min) 1) SERIAL_RELEASE => passed: passed=361,notpassed=0 (1.29 min) Other local commits for this build/test group: 3c9eeaa, 0db30ec

Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit 0db30ecb5f7f27dd75964cb320f5cc3a3ddb90a0 Author: Roscoe A. Bartlett <[email protected]> Date: Tue Sep 17 11:17:47 2019 -0600 Summary: Only export library targets for a package that has native libs to install (#5314)

…bs to install (trilinos#5314) This was needed because the Trilinos Gtest package now has a mode where it will not install its library (but allows tests in downstream packages to use it). I changed the variable ${PACKAGE_NAME}_HAS_NATIVE_LIBRARIES to ${PACKAGE_NAME}_HAS_NATIVE_LIBRARIES_TO_INSTALL since that is how it is actually used.

…s:develop' (adfb455). * trilinos-develop: (34 commits) MueLu: reduce default no of iterations in regin MG MueLu: move regionMG scaleInterfaceDOFs() MueLu: remove unused gold file from region MG MueLu: remove unused header inclusions MueLu: create header for regionMG vector stuff Move matrix regionToComposite to matrix header MueLu: fix script for regionMG regression tests MueLu: add some documentation MueLu: deal with regionMG coarse solver options MueLu: fix indentation MueLu: Typo ugh Update documentation for setting Trilinos_ENABLE_DEBUG=ON (trilinos#4201) Move Gtest_SKIP_INSTALL=TRUE to EMPIRE config only for now (trilinos#5341, SPAR-614) ShyLU_NodeTacho: Remove stated lib dependency on Gtest (trilinos#5341) STK: Don't install if Gtest_SKIP_INSTALL=TRUE (trilinos#5341) STK: Remove parent STK deps on all other SE packages (trilinos#5341) ATDM: Disable install of Gtest from Trilinos, disable expensive Panzer tests in debug (trilinos#5341) Gtest: Add option Gtest_SKIP_INSTALL and cleanup (trilinos#5341) TriBITS: Only export library targets for a package that has native libs to install (trilinos#5314) Gtest: Use TRIBITS_PACKAGE_DEFINE_DEPENDENCIES() (trilinos#5341) ...

mhoemmen · 2020-02-14T19:24:38Z

#5117 is fixed now, so we can close this PR.

Mark Hoemmen added 3 commits June 4, 2019 11:21

Tpetra: Purge all but 1 instance of DynamicProfile from core/test

e455be1

@trilinos/tpetra

Tpetra: Make TpetraCore build w/ deprecated code off

e8a06c1

@trilinos/tpetra I haven't tested downstream code yet.

Tpetra: Fix some tests when deprecated code is off

a8acad2

@trilinos/tpetra

mhoemmen added pkg: Tpetra TpetraRF labels Jun 4, 2019

mhoemmen requested review from william76, tjfulle, cgcgcg, DrBooom, kddevin, GeoffDanielson and lucbv June 4, 2019 20:55

mhoemmen self-assigned this Jun 4, 2019

mhoemmen changed the base branch from master to develop June 4, 2019 20:55

mhoemmen changed the title ~~Tpetra: Fix #5117; make TpetraCore build w/ DynamicProfile deprecated~~ Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled) Jun 4, 2019

csiefer2 approved these changes Jun 4, 2019

View reviewed changes

mhoemmen added AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) and removed AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels Jun 4, 2019

mhoemmen changed the title ~~Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled)~~ (DO NOT MERGE) Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled) Jun 4, 2019

kddevin added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Jun 5, 2019

kddevin requested changes Jun 5, 2019

View reviewed changes

bartlettroscoe added a commit to TriBITSPub/TriBITS that referenced this pull request Sep 17, 2019

Update name change to <Pkg>_HAS_NATIVE_LIBRARIES_TO_INSTALL (trilinos…

3c9eeaa

…/Trilinos#5314)

mhoemmen closed this Feb 14, 2020

trilinos-autotester mentioned this pull request Apr 14, 2022

Tacho structure symmetric LU solver for CPU and GPU #10406

Merged

(DO NOT MERGE) Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled) #5314

(DO NOT MERGE) Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled) #5314

Conversation

mhoemmen commented Jun 4, 2019

Description

Related Issues

trilinos-autotester commented Jun 4, 2019

trilinos-autotester commented Jun 4, 2019

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Jenkins Parameters

Using Repos:

mhoemmen commented Jun 4, 2019

tjfulle commented Jun 4, 2019

mhoemmen commented Jun 4, 2019

trilinos-autotester commented Jun 5, 2019

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

Jenkins Parameters

trilinos-autotester commented Jun 5, 2019

trilinos-autotester commented Jun 5, 2019

kddevin commented Jun 5, 2019

kddevin left a comment

Choose a reason for hiding this comment

mhoemmen commented Feb 14, 2020