Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile #5117

mhoemmen · 2019-05-07T02:25:59Z

Bug Report

@trilinos/tpetra

Description

When I disable deprecated code in Tpetra, I get the following build errors:

In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_SerialWrapperNode.cpp:52:
.../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_decl.hpp:2582:59: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
    return rcp (new graph_type (map, maxNumEntriesPerRow, DynamicProfile, params));
                                                          ^~~~~~~~~~~~~~
                                                          StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_SerialWrapperNode.cpp:54:
In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_def.hpp:66:
In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_Import_Util2.hpp:64:
.../Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_decl.hpp:5039:43: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
                                          DynamicProfile, params));
                                          ^~~~~~~~~~~~~~
                                          StaticProfile

When I fix those and enable tests, I get the following build errors:

.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_insertGlobalIndicesFiltered.cpp:137:16: error: no member
      named 'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
      {Tpetra::DynamicProfile, Tpetra::StaticProfile};
       ~~~~~~~~^~~~~~~~~~~~~~
               StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
...
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:51:17: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
  using Tpetra::DynamicProfile;
        ~~~~~~~~^~~~~~~~~~~~~~
                StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:143:25: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
      GRAPH graph(map,1,DynamicProfile);
                        ^~~~~~~~~~~~~~
                        StaticProfile
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:53:17: note: 'StaticProfile' declared here
  using Tpetra::StaticProfile;
                ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:459:29: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
      GRAPH graph(map,map,0,DynamicProfile);
                            ^~~~~~~~~~~~~~
                            StaticProfile
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:53:17: note: 'StaticProfile' declared here
  using Tpetra::StaticProfile;
                ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:474:29: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
      GRAPH graph(map,map,0,DynamicProfile);
                            ^~~~~~~~~~~~~~
                            StaticProfile
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:53:17: note: 'StaticProfile' declared here
  using Tpetra::StaticProfile;
                ^

When I fix those build errors, I get the following:

.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests_Swap.cpp:415:15: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
using Tpetra::DynamicProfile;
      ~~~~~~~~^~~~~~~~~~~~~~
              StaticProfile

When I fix that, I get the following:

.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_Issue601.cpp:100:52: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
    Tpetra::ProfileType profileTypes[] = { Tpetra::DynamicProfile, Tpetra::StaticProfile };
                                           ~~~~~~~~^~~~~~~~~~~~~~
                                                   StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_Issue601.cpp:107:39: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
          << ((profileType == Tpetra::DynamicProfile) ? "Dynamic" : "Static")
                              ~~~~~~~~^~~~~~~~~~~~~~
                                      StaticProfile

I get a few more after this in other tests in TpetraCore.

Steps to Reproduce

SHA1: 2b9c4fe

The text was updated successfully, but these errors were encountered:

@trilinos/tpetra TpetraCore's tests and examples build, but some tests still fail.

mhoemmen · 2019-05-07T03:24:47Z

When I fixed build errors, some Tpetra tests failed. Here is my PR with the attempt: #5118 (don't merge it yet!).

@trilinos/tpetra Issue: trilinos#5117 - Fixes build errors in Tpetra's `CrsMatrix::createCrsMatrix` and `CrsGraph::createCrsGraph` associated with `DynamicProfile` - Fixes many build errors in Tpetra's tests Still has one build error: ``` duplicate symbol typeinfo name for Tpetra::Experimental::BlockMultiVector<double, int, long long, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > in: packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector.cpp.o packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector_DOUBLE_INT_LONG_LONG_SERIAL.cpp.o duplicate symbol typeinfo for Tpetra::Experimental::BlockMultiVector<double, int, long long, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > in: packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector.cpp.o packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector_DOUBLE_INT_LONG_LONG_SERIAL.cpp.o ld: 2 duplicate symbols for architecture x86_64 collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. ```

tjfulle · 2019-05-09T17:54:53Z

Hmmm, after fixing the build errors (see branch tjfulle/Trilinos@c6d04b22) associated with DynamicProfile, I get a link error:

duplicate symbol typeinfo name for Tpetra::Experimental::BlockMultiVector<double, int, long long, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > in:
    packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector.cpp.o
    packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector_DOUBLE_INT_LONG_LONG_SERIAL.cpp.o
duplicate symbol typeinfo for Tpetra::Experimental::BlockMultiVector<double, int, long long, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > in:
    packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector.cpp.o
    packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockMultiVector_DOUBLE_INT_LONG_LONG_SERIAL.cpp.o
ld: 2 duplicate symbols for architecture x86_64
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

mhoemmen · 2019-05-10T15:24:51Z

@tjfulle Where does this link error occur? -- on what file?

tjfulle · 2019-05-15T21:45:29Z

I have a branch that now builds. Many tests fail because export/import operations that resize the target matrix are not yet supported (as they are for CrsGraph, see #4147). The tests could be made to pass by allocating sufficient space to the target matrices, but a longer term solution is to modify CrsMatrix to allow a target matrix (with static profile) to expand during import/export, which is being tracked in #5164

mhoemmen · 2019-06-04T20:59:57Z

Given that #5268 merged into develop 3 days ago and is probably in master by now, can we consider #5164 fixed?

kddevin · 2019-06-05T18:54:05Z

This issue duplicates #5065.
PR #5326 is a step toward resolving it.

bartlettroscoe · 2019-06-08T14:30:15Z

This is vomiting hundreds of warnings all over the SPARC build:

/scratch/rabartl/SPARC.base/sparc/Trilinos/spack-rhel6_gnu-7.2.0_serial_static_opt/include/Tpetra_CrsMatrix_decl.hpp:5039:43: warning: ‘Tpetra::DynamicProfile’ is deprecated [-Wdeprecated-declarations]
                                           DynamicProfile, params));
                                           ^~~~~~~~~~~~~~

There is nothing they can do to avoid these warnings since they are in Trilinos.

We need to have a policy that if someone is going to deprecate something in Trilinos then they need to build all downstream Trilinos packages and remove usage of all deprecated usage in those packages.

kddevin · 2019-06-13T22:02:35Z

We are deprecating DynamicProfile construction in Tpetra. We have removed many downstream uses (e.g., #4350 #4351 #4411 #5326 #5268 #5130 #4701). Some cases remain (e.g., #5065 and this issue). The warning generation will continue to reduce over the next weeks. Thanks for your patience.

bartlettroscoe · 2019-06-13T22:34:08Z

Can't these particular deprecated warnings be turned off by default until all of the usages of these deprecated warnings can be removed from Trilinos? Then Tpetra and other developers can turn back on these particular warnings at will to keep working on getting rid if their usage downstream in Trilinos. I can show how this would work. It is very little CMake and C++ preprocessor code.

What we are doing right now is training users of Trilinos to ignore deprecated warnings which defeats the purpose of deprecated warnings.

…s:develop' (d1e19b9). * trilinos-develop: Error out if trying to set Kokkos Pthreads backend (TRIL-272) tpetra: changes to reduce the number of deprecated warnings issued trilinos#5117 Tpetra: Fix trilinos#5408 (build warning in CrsGraph) Tpetra::CrsMatrix: Fix trilinos#5407 Teuchos::ParameterList: Fix 2 shadowing warnings Tpetra: Add benchmark for CrsMatrix::sumIntoLocalValues

mhoemmen added type: bug The primary issue is a bug in Trilinos code or tests impacting: configure or build The issue is primarily related to configuring or building pkg: Tpetra labels May 7, 2019

mhoemmen changed the title ~~PackageName: General Summary of the Bug~~ Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile May 7, 2019

mhoemmen pushed a commit to mhoemmen/Trilinos that referenced this issue May 7, 2019

Tpetra: Attempt to fix trilinos#5117

ad792be

@trilinos/tpetra TpetraCore's tests and examples build, but some tests still fail.

mhoemmen mentioned this issue May 7, 2019

Tpetra: Attempt to Fix #5117 #5118

Closed

tjfulle self-assigned this May 7, 2019

mhoemmen mentioned this issue May 7, 2019

#5042: add throw to row matrix add #5126

Merged

8 tasks

tjfulle mentioned this issue May 13, 2019

Tpetra: Tpetra_Experimental_BlockMultiVector link errors #5161

Closed

mhoemmen mentioned this issue May 15, 2019

Tpetra, Xpetra, Amesos2, MueLu, and PanzerAdaptersSTK_* tests failing in many ATDM cuda 9.2 builds with Kokkos view bounds errors starting before 2019-05-15 #5179

Closed

mhoemmen mentioned this issue Jun 4, 2019

(DO NOT MERGE) Tpetra: Fix #5117 (make TpetraCore build w/ deprecated code disabled) #5314

Closed

kddevin mentioned this issue Jun 5, 2019

Tpetra DynamicProfile deprecation: some fixes for #5065 #5326

Merged

kddevin added a commit that referenced this issue Jun 19, 2019

tpetra: changes to reduce the number of deprecated warnings issued #5117

3f46de2

kddevin mentioned this issue Jun 19, 2019

Tpetra: changes to reduce the number of deprecated warnings issued #5419

Merged

kddevin closed this as completed Jan 14, 2020

trilinos-autotester mentioned this issue Jun 3, 2020

Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200601_000612 branch to master #7459

Merged

trilinos-autotester mentioned this issue Jul 22, 2021

Xpetra: HIP support #9466

Merged

trilinos-autotester mentioned this issue Mar 31, 2022

Tpetra: Fixing #10390 #10391

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile #5117

Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile #5117

mhoemmen commented May 7, 2019 •

edited

Loading

mhoemmen commented May 7, 2019

tjfulle commented May 9, 2019

mhoemmen commented May 10, 2019

tjfulle commented May 15, 2019

mhoemmen commented Jun 4, 2019

kddevin commented Jun 5, 2019

bartlettroscoe commented Jun 8, 2019

kddevin commented Jun 13, 2019

bartlettroscoe commented Jun 13, 2019

Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile #5117

Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile #5117

Comments

mhoemmen commented May 7, 2019 • edited Loading

Bug Report

Description

Steps to Reproduce

mhoemmen commented May 7, 2019

tjfulle commented May 9, 2019

mhoemmen commented May 10, 2019

tjfulle commented May 15, 2019

mhoemmen commented Jun 4, 2019

kddevin commented Jun 5, 2019

bartlettroscoe commented Jun 8, 2019

kddevin commented Jun 13, 2019

bartlettroscoe commented Jun 13, 2019

mhoemmen commented May 7, 2019 •

edited

Loading