Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: Allow CrsMatrix import/export to change its graph's structure #5164

Closed
tjfulle opened this issue May 13, 2019 · 5 comments
Closed

Tpetra: Allow CrsMatrix import/export to change its graph's structure #5164

tjfulle opened this issue May 13, 2019 · 5 comments

Comments

@tjfulle
Copy link
Contributor

tjfulle commented May 13, 2019

Enhancement

@trilinos/tpetra

PR #4147 allows import/export operations to change the structure of a CrsGraph. Importantly, the user cannot change the structure directly, the structure changes happen in internal CrsGraph methods.

@kddevin and @mhoemmen should CrsMatrix provide the same functionality?

The answer to whether or not CrsMatrix does provide the functionality will have implications on many tests that fail with deprecated code OFF.

@tjfulle tjfulle added type: enhancement Issue is an enhancement, not a bug pkg: Tpetra TpetraRF labels May 13, 2019
@mhoemmen
Copy link
Contributor

@tjfulle asked:

@kddevin and @mhoemmen should CrsMatrix provide the same functionality?

Yes, but only if the target CrsMatrix owns its graph. If the target CrsMatrix was created with a const graph (the RCP<const crs_graph_type> constructor), then it does not have permission to change the graph.

@mhoemmen
Copy link
Contributor

We pretty much need this in order to deprecate and remove DynamicProfile safely, so I'm removing the "enhancement" flag.

@mhoemmen
Copy link
Contributor

mhoemmen commented Jun 4, 2019

@tjfulle #5268 merged 3 days ago. Did it get into master? If so, can we consider this issue fixed?

@tjfulle
Copy link
Contributor Author

tjfulle commented Jun 4, 2019

I think so, I must not have put the right magic in the commit logs for it to close automagically

@mhoemmen
Copy link
Contributor

mhoemmen commented Jun 4, 2019

Thanks @tjfulle ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants