fix some valgrind memcheck warnings when N_proc < NN #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slava77
reviewed
Oct 31, 2023
| if (n < N_proc) { | ||
| const float zout = msZ.constAt(n, 0, 0); | ||
| const float zin = inPar.constAt(n, 2, 0); | ||
| propSign(n, 0, 0) = (std::abs(zout) > std::abs(zin) ? 1. : -1.); |
There was a problem hiding this comment.
Probably best to wait for #136 to be merged and then I'll rebase
…idate and cleanup TkElectron interface
…n pv-based isolation. Set charge of TkElectrons
|
after the prop to plane was merged I did a resync in our/trackreco fork. |
…th DeepCoreSeeding ProcModifiers
Extend the GenericConsumer to support the possibility of consuming the individual products produced by a module. The new syntax is similar to the "keep" statements in an OutputModule. The old syntax, specifying only the module label, is still supported.
1. Compatibility issue with Python 3: Encode the `file_name` argument before computing the hash. 2. Import the `hashlib` module for the development environment
Run3-sim152X Make changes which can handle both DDD and DD4hep inputs correctly
Cleanup unnecessary include statements from L1Trigger/L1TMuonOverlapPhase1
Run3-alca248Z Modify the calibration code of HCAL to ignore the zside index and also change the name of some variables
…hcal
Removing unnecessary try/catch clauses in Hcal{Led,Pedestal}Analysis.cc
Measurements of HLT job timing showed that the first calls to tensflow take a long time and hold a mutex for that entire time. This lead to poor thread efficiency during the start of event processing.
…SumPtHollowConeDR03 trkSumPtSolidConeDR04 to 10
Also improved UI in the viewer.
Update the DependencyGraph service
Increase precision of photon variables to 10
L1T o2o: fix int/2 bug
Add module centric view to Tracer viewer
Added tensorflow initialization to TSGForOIDNN
Remove legacy modules cleanup, last ones in reco packages
…rDgt98 more all D* geometry >= D98 to use the @relval2026 menu
[14_0_X SIM] Added ZDC transport as an option of FullSim for heavy ion simulation
…rmwareStyle Emulator cluster firmware style
…ndowTune New l1 track trigger stub window tune
…nter-warn [nonlto] Fixed dangling-pointer warning in MkFitCore
…s in producer destructor
dan131riley
force-pushed
the
mkfit-valgrind
branch
from
b39a0e0 to
477556d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
valgrind memcheck complained about uninitialised values in a few new places where we loop over NN. This PR quiets them. My working theory is that a loop over constant NN with an if on N_proc is more vectorizable than a loop over an unbounded N_proc.
PR validation:
Compiles, quiets valgrind, trivial technical fix.