Run3-alca248Z Modify the calibration code of HCAL to ignore the zside index and also change the name of some variables

[bsunanda]

PR description:

Modify the calibration code of HCAL to ignore the zside index and also change the name of some variables

PR validation:

Use the modified macros to obtain new sets of correction factors

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43480/38044

• This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43480/38044/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43480/38044/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43480/38045

• This PR adds an extra 76KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalCalibAlgos (alca)

@saumyaphor4252, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@tocheng, @yuanchao, @mmusich, @rsreds this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa67e8/36275/summary.html
COMMIT: 3f6df94
CMSSW: CMSSW_14_0_X_2023-12-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43480/36275/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 52 lines from the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 1194
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3368816
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

@bsunanda , just checking: shouldn't truncateFlag be considered a two digits number also when it is given as argument of truncateDepth (see https://github.com/cms-sw/cmssw/blob/3f6df943398131278e59bafce0294d2212a6b872/Calibration/HcalCalibAlgos/macros/CalibCorr.C#L180C44-L180C55)?

[bsunanda]

@perrotta Taken care of it. Thanks for pointing this

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43480/38077

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #43480 was updated. @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa67e8/36334/summary.html
COMMIT: beb06a5
CMSSW: CMSSW_14_0_X_2023-12-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43480/36334/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 382 lines to the logs
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3430794
• DQMHistoTests: Total failures: 1283
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3429489
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1