Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module centric view to Tracer viewer #43514

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Improved UI in the viewer.
Added unit tests.

PR validation:

Code was tested with HLT tracer log output.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43514/38093

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • FWCore/Services (core)

@Dr15Jones, @smuzaffar, @makortel, @cmsbuild can you please review it and eventually sign? Thanks.
@wddgit, @missirol, @makortel, @fwyzard this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

please test

Also improved UI in the viewer.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43514/38094

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

Pull request #43514 was updated. @makortel, @Dr15Jones, @cmsbuild, @smuzaffar can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ead83/36362/summary.html
COMMIT: 28cbcbd
CMSSW: CMSSW_14_0_X_2023-12-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43514/36362/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

makortel commented Dec 7, 2023

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 I have another change dependent upon this one I've just finished. It would be helpful to merge this so I can open a PR with the next change.

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 please merge as this is holding up other developments.

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b047ff7 into cms-sw:master Dec 8, 2023
@Dr15Jones Dr15Jones deleted the moduleCentricTracer branch December 18, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants