-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module centric view to Tracer viewer #43514
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43514/38093
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@Dr15Jones, @smuzaffar, @makortel, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test |
Also improved UI in the viewer.
aec09ba
to
28cbcbd
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43514/38094
|
Pull request #43514 was updated. @makortel, @Dr15Jones, @cmsbuild, @smuzaffar can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ead83/36362/summary.html Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 I have another change dependent upon this one I've just finished. It would be helpful to merge this so I can open a PR with the next change. |
@cms-sw/orp-l2 please merge as this is holding up other developments. |
+1 |
PR description:
Improved UI in the viewer.
Added unit tests.
PR validation:
Code was tested with HLT tracer log output.