metrics: fix the residual label #4824

rleungx · 2022-04-20T06:40:52Z

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #4825.

What is changed and how it works?

Before collecting the metrics, reset the placementStatusGauge

Check List

Tests

Manual test (the detailed steps can be found in the above issue)

Release note

Fix the issue that the label distribution has residual labels

Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot · 2022-04-20T06:40:53Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-04-20T06:49:13Z

Codecov Report

Merging #4824 (378d9c4) into master (783d060) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4824   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files         295      295           
  Lines       28809    28810    +1     
=======================================
+ Hits        21709    21710    +1     
+ Misses       5182     5181    -1     
- Partials     1918     1919    +1

Flag	Coverage Δ
unittests	`75.35% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/statistics/store_collection.go	`95.10% <100.00%> (+0.03%)`	⬆️
pkg/tempurl/tempurl.go	`45.00% <0.00%> (-15.00%)`	⬇️
server/tso/local_allocator.go	`71.62% <0.00%> (-6.76%)`	⬇️
server/id/id.go	`76.19% <0.00%> (-4.77%)`	⬇️
server/tso/tso.go	`61.71% <0.00%> (-4.01%)`	⬇️
server/server.go	`74.21% <0.00%> (-1.72%)`	⬇️
server/cluster/cluster.go	`85.90% <0.00%> (-0.35%)`	⬇️
server/grpc_service.go	`53.87% <0.00%> (-0.18%)`	⬇️
client/client.go	`69.03% <0.00%> (-0.11%)`	⬇️
server/handler.go	`53.21% <0.00%> (+0.38%)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783d060...378d9c4. Read the comment docs.

CabinfeverB

LGTM

nolouch · 2022-04-21T03:13:01Z

/merge

nolouch · 2022-04-21T03:13:01Z

/merge

ti-chi-bot · 2022-04-21T03:13:02Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-21T03:13:02Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-21T03:13:04Z

This pull request has been accepted and is ready to merge.

Commit hash: 378d9c4

ti-chi-bot · 2022-04-21T03:13:04Z

This pull request has been accepted and is ready to merge.

Commit hash: 378d9c4

nolouch · 2022-04-21T05:47:20Z

/merge

ti-chi-bot · 2022-04-21T05:47:21Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-21T05:52:50Z

In response to a cherrypick label: new pull request created: #4826.

ti-chi-bot · 2022-04-21T05:53:25Z

In response to a cherrypick label: new pull request created: #4827.

ti-chi-bot · 2022-04-21T05:54:01Z

In response to a cherrypick label: new pull request created: #4828.

ti-chi-bot · 2022-04-21T05:54:37Z

In response to a cherrypick label: new pull request created: #4829.

ti-chi-bot · 2022-04-21T05:55:12Z

In response to a cherrypick label: new pull request created: #4830.

ti-chi-bot · 2022-04-21T05:55:48Z

In response to a cherrypick label: new pull request created: #4831.

ref #4824, close #4825 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

fix the residual label

378d9c4

Signed-off-by: Ryan Leung <[email protected]>

ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 20, 2022

ti-chi-bot requested review from disksing and nolouch April 20, 2022 06:41

ti-chi-bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Apr 20, 2022

rleungx marked this pull request as ready for review April 20, 2022 06:52

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022

lhy1024 approved these changes Apr 20, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2022

CabinfeverB approved these changes Apr 20, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2022

HunDunDM approved these changes Apr 20, 2022

View reviewed changes

nolouch added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. labels Apr 21, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2022

nolouch removed the do-not-merge/needs-triage-completed label Apr 21, 2022

ti-chi-bot merged commit 6c5d61c into tikv:master Apr 21, 2022

ti-chi-bot mentioned this pull request Apr 21, 2022

metrics: fix the residual label (#4824) #4826

Merged

ti-chi-bot mentioned this pull request Apr 21, 2022

metrics: fix the residual label (#4824) #4827

Closed

This was referenced Apr 21, 2022

metrics: fix the residual label (#4824) #4828

Merged

metrics: fix the residual label (#4824) #4829

Merged

This was referenced Apr 21, 2022

metrics: fix the residual label (#4824) #4830

Merged

metrics: fix the residual label (#4824) #4831

Merged

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022

metrics: fix the residual label (#4824) (#4826)

1583c0f

ref #4824, close #4825 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

ti-chi-bot added a commit that referenced this pull request May 27, 2022

metrics: fix the residual label (#4824) (#4831)

b73b12d

ref #4824, close #4825 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

ti-chi-bot added a commit that referenced this pull request May 27, 2022

metrics: fix the residual label (#4824) (#4830)

c7baa24

ref #4824, close #4825 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

ti-chi-bot added a commit that referenced this pull request Jun 13, 2022

metrics: fix the residual label (#4824) (#4828)

bcf3615

ref #4824, close #4825 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

ti-chi-bot added a commit that referenced this pull request Jun 13, 2022

metrics: fix the residual label (#4824) (#4829)

f88ec89

ref #4824, close #4825 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

metrics: fix the residual label #4824

metrics: fix the residual label #4824

rleungx commented Apr 20, 2022 •

edited

Loading

ti-chi-bot commented Apr 20, 2022 •

edited

Loading

codecov bot commented Apr 20, 2022 •

edited

Loading

CabinfeverB left a comment

nolouch commented Apr 21, 2022

nolouch commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

nolouch commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

metrics: fix the residual label #4824

metrics: fix the residual label #4824

Conversation

rleungx commented Apr 20, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Apr 20, 2022 • edited Loading

codecov bot commented Apr 20, 2022 • edited Loading

Codecov Report

CabinfeverB left a comment

Choose a reason for hiding this comment

nolouch commented Apr 21, 2022

nolouch commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

nolouch commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

ti-chi-bot commented Apr 21, 2022

rleungx commented Apr 20, 2022 •

edited

Loading

ti-chi-bot commented Apr 20, 2022 •

edited

Loading

codecov bot commented Apr 20, 2022 •

edited

Loading