-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: fix the residual label (#4824) #4826
metrics: fix the residual label (#4824) #4826
Conversation
Signed-off-by: Ryan Leung <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-tests |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f03d587
|
Codecov Report
@@ Coverage Diff @@
## release-5.4 #4826 +/- ##
===============================================
+ Coverage 74.64% 74.69% +0.04%
===============================================
Files 265 265
Lines 27963 27964 +1
===============================================
+ Hits 20874 20888 +14
+ Misses 5220 5210 -10
+ Partials 1869 1866 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is an automated cherry-pick of #4824
Signed-off-by: Ryan Leung [email protected]
What problem does this PR solve?
Issue Number: Close #4825.
What is changed and how it works?
Before collecting the metrics, reset the
placementStatusGauge
Check List
Tests
Release note