Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix the residual label (#4824) #4826

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4824

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #4825.

What is changed and how it works?

Before collecting the metrics, reset the placementStatusGauge

Check List

Tests

  • Manual test (the detailed steps can be found in the above issue)

Release note

Fix the issue that the label distribution has residual labels

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Apr 21, 2022
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. label Apr 21, 2022
@ti-chi-bot ti-chi-bot requested review from lhy1024 and rleungx April 21, 2022 05:52
@rleungx
Copy link
Member

rleungx commented Apr 26, 2022

/run-unit-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2022
@rleungx
Copy link
Member

rleungx commented Apr 26, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f03d587

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #4826 (df39baf) into release-5.4 (eed291d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-5.4    #4826      +/-   ##
===============================================
+ Coverage        74.64%   74.69%   +0.04%     
===============================================
  Files              265      265              
  Lines            27963    27964       +1     
===============================================
+ Hits             20874    20888      +14     
+ Misses            5220     5210      -10     
+ Partials          1869     1866       -3     
Flag Coverage Δ
unittests 74.69% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/store_collection.go 93.70% <100.00%> (+0.04%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/schedule/operator_controller.go 83.02% <0.00%> (-1.23%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/tso/allocator_manager.go 65.39% <0.00%> (-0.84%) ⬇️
server/region_syncer/client.go 78.90% <0.00%> (-0.79%) ⬇️
client/client.go 72.83% <0.00%> (+0.10%) ⬆️
server/server.go 71.85% <0.00%> (+0.14%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed291d...df39baf. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 1583c0f into tikv:release-5.4 Apr 26, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants