metrics: fix the residual label (#4824)

[ti-chi-bot]

This is an automated cherry-pick of #4824

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #4825.

What is changed and how it works?

Before collecting the metrics, reset the placementStatusGauge

Check List

Tests

• Manual test (the detailed steps can be found in the above issue)

Release note

Fix the issue that the label distribution has residual labels

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• disksing
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[rleungx]

/run-all-tests

[rleungx]

/run-unit-tests

[rleungx]

/run-unit-tests

[codecov]

Codecov Report

Merging #4828 (ebaae6f) into release-5.0 (552c53e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-5.0    #4828      +/-   ##
===============================================
- Coverage        74.98%   74.96%   -0.03%     
===============================================
  Files              245      245              
  Lines            24446    24447       +1     
===============================================
- Hits             18331    18326       -5     
- Misses            4500     4503       +3     
- Partials          1615     1618       +3     

Flag	Coverage Δ
unittests	74.96% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/statistics/store_collection.go	95.20% <100.00%> (+0.03%)	⬆️
pkg/tempurl/tempurl.go	45.00% <0.00%> (-15.00%)	⬇️
server/id/id.go	76.19% <0.00%> (-4.77%)	⬇️
pkg/etcdutil/etcdutil.go	84.70% <0.00%> (-3.53%)	⬇️
client/base_client.go	82.98% <0.00%> (-1.55%)	⬇️
server/tso/global_allocator.go	71.01% <0.00%> (-1.45%)	⬇️
tools/pd-ctl/pdctl/command/operator.go	65.99% <0.00%> (-1.22%)	⬇️
pkg/btree/btree.go	85.30% <0.00%> (-0.97%)	⬇️
server/handler.go	41.97% <0.00%> (-0.50%)	⬇️
server/server.go	72.43% <0.00%> (-0.46%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552c53e...ebaae6f. Read the comment docs.

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: ebaae6f