Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A diff of go mod left when executing make #5160

Closed
rleungx opened this issue Jun 15, 2022 · 0 comments · Fixed by #5183
Closed

A diff of go mod left when executing make #5160

rleungx opened this issue Jun 15, 2022 · 0 comments · Fixed by #5183
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jun 15, 2022 •
edited
Loading

Bug Report

What did you do?

In #4934, we remove github.com/alecthomas/template item in the mod. But if we have already generated the docs.go or run make swagger-spec. There will be a diff of go mod left when executing make or make pd-server

What did you expect to see?

There is nothing being changed.

What did you see instead?

diff --git a/go.mod b/go.mod
index 5eeb265..ac906d6 100644
--- a/go.mod
+++ b/go.mod
@@ -5,6 +5,7 @@ go 1.16
 require (
        github.com/AlekSi/gocov-xml v1.0.0
        github.com/BurntSushi/toml v0.3.1
+       github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751
        github.com/aws/aws-sdk-go v1.35.3
        github.com/axw/gocov v1.0.0
        github.com/cakturk/go-netstat v0.0.0-20200220111822-e5b49efee7a5
diff --git a/go.sum b/go.sum
index 5099769..702a4b7 100644
--- a/go.sum
+++ b/go.sum
@@ -24,6 +24,7 @@ github.com/VividCortex/mysqlerr v1.0.0/go.mod h1:xERx8E4tBhLvpjzdUyQiSfUxeMcATEQ
 github.com/Xeoncross/go-aesctr-with-hmac v0.0.0-20200623134604-12b17a7ff502 h1:L8IbaI/W6h5Cwgh0n4zGeZpVK78r/jBf9ASurHo9+/o=
 github.com/Xeoncross/go-aesctr-with-hmac v0.0.0-20200623134604-12b17a7ff502/go.mod h1:pmnBM9bxWSiHvC/gSWunUIyDvGn33EkP2CUjxFKtTTM=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
+github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 h1:JYp7IbQjafoB+tBA3gMyHYHrpOtNuDiK/uB5uXxq5wM=
 github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
 github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
 github.com/alvaroloes/enumer v1.1.2/go.mod h1:FxrjvuXoDAx9isTJrv4c+T410zFi0DtXIT0m65DJ+Wo=

What version of PD are you using (pd-server -V)?
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jun 15, 2022
@rleungx rleungx added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 15, 2022
@rleungx rleungx mentioned this issue Jun 20, 2022
Merged
@rleungx rleungx added affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/minor labels Jun 21, 2022
ti-chi-bot added a commit that referenced this issue Jun 21, 2022
@rleungx @ti-chi-bot
*: update the swagger dependency (#5183)
01b8f34 
close #5160

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 21, 2022
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#5183
050893b 
close tikv#5160

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 21, 2022
Merged
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@rleungx @ti-chi-bot @CabinfeverB
*: update the swagger dependency (tikv#5183)
f81e057 
close tikv#5160

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot added a commit that referenced this issue Jul 18, 2022
@ti-chi-bot @rleungx
*: update the swagger dependency (#5183) (#5194)
061f671 
close #5160, ref #5183

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update the swagger dependency rleungx/pd
2 participants
@VelocityLight @rleungx