Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: disable swagger server #4934

Merged
merged 4 commits into from
May 20, 2022
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 12, 2022

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

Issue Number: Close #4932

before:
make pd-server  213.93s user 43.70s system 279% cpu 1:32.05 total
after:
make pd-server  209.82s user 37.90s system 286% cpu 1:26.54 to

imporve about 5/43.7 = 11%

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

server: disable swagger server

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 12, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and JmPotato May 12, 2022 07:14
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #4934 (78fcc45) into master (aafc77d) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4934      +/-   ##
==========================================
- Coverage   75.58%   75.41%   -0.17%     
==========================================
  Files         307      307              
  Lines       30230    30230              
==========================================
- Hits        22850    22799      -51     
- Misses       5395     5439      +44     
- Partials     1985     1992       +7     
Flag Coverage Δ
unittests 75.41% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/swaggerserver/empty_handler.go 0.00% <0.00%> (ø)
server/region_syncer/server.go 82.06% <0.00%> (-5.44%) ⬇️
pkg/dashboard/adapter/manager.go 74.71% <0.00%> (-4.60%) ⬇️
server/tso/allocator_manager.go 61.89% <0.00%> (-4.33%) ⬇️
pkg/etcdutil/etcdutil.go 85.05% <0.00%> (-3.45%) ⬇️
server/tso/tso.go 70.05% <0.00%> (-3.39%) ⬇️
server/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
server/encryptionkm/key_manager.go 72.90% <0.00%> (-0.80%) ⬇️
client/client.go 68.41% <0.00%> (-0.63%) ⬇️
server/cluster/unsafe_recovery_controller.go 81.03% <0.00%> (-0.40%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafc77d...78fcc45. Read the comment docs.

@nolouch
Copy link
Contributor Author

nolouch commented May 13, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2022
Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Contributor Author

nolouch commented May 20, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2022
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label May 20, 2022
@nolouch
Copy link
Contributor Author

nolouch commented May 20, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78fcc45

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2022
@ti-chi-bot ti-chi-bot merged commit 2cced16 into tikv:master May 20, 2022
@nolouch nolouch deleted the disable-swag branch May 20, 2022 11:01
@nolouch
Copy link
Contributor Author

nolouch commented May 23, 2022

/run-cherry-picker

@nolouch nolouch added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 23, 2022
@nolouch
Copy link
Contributor Author

nolouch commented May 23, 2022

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5012.

ti-chi-bot added a commit that referenced this pull request May 23, 2022
close #4932, ref #4934

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
@nolouch nolouch added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Jun 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5176.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5177.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5179.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5178.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5180.

@nolouch
Copy link
Contributor Author

nolouch commented Jun 17, 2022

/run-cheery-picker

ti-chi-bot added a commit that referenced this pull request Jun 20, 2022
close #4932, ref #4934

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 24, 2022
close #4932, ref #4934

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 24, 2022
close #4932, ref #4934

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 24, 2022
close #4932, ref #4934

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 24, 2022
close #4932, ref #4934

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable compile swag server by default
3 participants