Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update the swagger dependency #5183

Merged
merged 2 commits into from
Jun 21, 2022
Merged

*: update the swagger dependency #5183

merged 2 commits into from
Jun 21, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 20, 2022

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #5160.

What is changed and how does it work?

Check List

Tests

  • Manual test (make swagger-spec)

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 20, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and nolouch June 20, 2022 05:04
@rleungx rleungx force-pushed the swag branch 2 times, most recently from 419bc7a to 6961108 Compare June 20, 2022 05:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #5183 (4382ff1) into master (e0f5b49) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5183   +/-   ##
=======================================
  Coverage   75.67%   75.68%           
=======================================
  Files         310      310           
  Lines       30675    30675           
=======================================
+ Hits        23213    23215    +2     
- Misses       5452     5458    +6     
+ Partials     2010     2002    -8     
Flag Coverage Δ
unittests 75.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/admin.go 67.44% <ø> (ø)
server/api/checker.go 82.75% <ø> (ø)
server/api/cluster.go 66.66% <ø> (ø)
server/api/config.go 61.50% <ø> (ø)
server/api/health.go 85.00% <ø> (ø)
server/api/hot_status.go 71.96% <ø> (ø)
server/api/label.go 84.00% <ø> (ø)
server/api/log.go 52.63% <ø> (ø)
server/api/member.go 53.22% <ø> (ø)
server/api/min_resolved_ts.go 100.00% <ø> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f5b49...4382ff1. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2022
@nolouch
Copy link
Contributor

nolouch commented Jun 20, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6961108

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed status/can-merge Indicates a PR has been approved by a committer. do-not-merge/needs-triage-completed labels Jun 20, 2022
@rleungx
Copy link
Member Author

rleungx commented Jun 21, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c7818dd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 01b8f34 into tikv:master Jun 21, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 21, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5194.

CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
close tikv#5160

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
close #5160, ref #5183

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A diff of go mod left when executing make
6 participants