Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): update Windows installer for Minotari #5614

Merged

Conversation

leet4tari
Copy link
Contributor

Description
Correct some of the paths for Minotari

Motivation and Context
Fix the Windows installer build

How Has This Been Tested?
Builds in local fork.

What process can a PR reviewer use to test or verify this change?
Check that a Windows installers is successfully created.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Test Results (CI)

1 182 tests   1 182 ✔️  21m 32s ⏱️
     37 suites         0 💤
       1 files           0

Results for commit 7e328a1.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Test Results (Integration tests)

27 tests  +27   27 ✔️ +27   16m 12s ⏱️ + 16m 12s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ±  0 

Results for commit 7e328a1. ± Comparison against base commit d4f0807.

♻️ This comment has been updated with latest results.

Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 7, 2023
@stringhandler stringhandler added the P-merge Process - Queued for merging label Aug 7, 2023
@stringhandler
Copy link
Collaborator

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-acks_required Process - Requires more ACKs or utACKs label Aug 7, 2023
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now, we still have to fix the actual installation.

utACK

@stringhandler stringhandler merged commit ff0208f into tari-project:development Aug 7, 2023
sdbondi added a commit to sdbondi/tari that referenced this pull request Aug 10, 2023
…-addresses

* development:
  chore: fix windows install (tari-project#5616)
  feat: ban peer unexpected response (tari-project#5608)
  fix!: add validator mr to mining hash (tari-project#5615)
  fix: check bytes remaining on monero blocks (tari-project#5610)
  fix: duplicate tari header in monero coinbase (tari-project#5604)
  fix: monero fork attack (tari-project#5603)
  feat: add mempool min fee (tari-project#5606)
  chore(tests): large block unit tests (tari-project#5599)
  fix: miner delay attack (tari-project#5582)
  fix: peer connection to stale nodes (tari-project#5579)
  ci(fix): artifact cleanup for diag-utils (tari-project#5613)
  ci(fix): update Windows installer for Minotari (tari-project#5614)
  chore: fixes monero build (tari-project#5612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-merge Process - Queued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants