fix: monero fork attack #5603
Merged
fix: monero fork attack #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
force-pushed
the
sw_fix_monero_attack
branch
from
a24ca9d to
c783b60
Compare
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Aug 10, 2023
…-addresses * development: chore: fix windows install (tari-project#5616) feat: ban peer unexpected response (tari-project#5608) fix!: add validator mr to mining hash (tari-project#5615) fix: check bytes remaining on monero blocks (tari-project#5610) fix: duplicate tari header in monero coinbase (tari-project#5604) fix: monero fork attack (tari-project#5603) feat: add mempool min fee (tari-project#5606) chore(tests): large block unit tests (tari-project#5599) fix: miner delay attack (tari-project#5582) fix: peer connection to stale nodes (tari-project#5579) ci(fix): artifact cleanup for diag-utils (tari-project#5613) ci(fix): update Windows installer for Minotari (tari-project#5614) chore: fixes monero build (tari-project#5612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forces the nonce of all Monero blocks to be 0.
Motivation and Context
The Nonce field in the header is used when calculating the hash of the block. When merge mining monero blocks, the nonce used by the monero mining sits in pow->monero_header->nonce. It does not use the tari block header nonce.
But this allows any node to change the nonce in the header and not break the mined pow, but change the hash of monero header. This will cause the network to fork of valid mined monero blocks.
How Has This Been Tested?
unit tests
RFC update: tari-project/rfcs#104