Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes monero build #5612

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes the monero-rs build by including the correct feature flag name

How Has This Been Tested?

It builds

What process can a PR reviewer use to test or verify this change?

Delete the cargo.lock file, and monero-rs will not build anymore.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Test Results (CI)

1 182 tests   1 182 ✔️  23m 43s ⏱️
     37 suites         0 💤
       1 files           0

Results for commit 8396f4c.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   15m 44s ⏱️ + 15m 44s
27 tests +27  26 ✔️ +26  0 💤 ±0  1 +1 
28 runs  +28  27 ✔️ +27  0 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 8396f4c. ± Comparison against base commit b1708fc.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 4, 2023
@SWvheerden SWvheerden merged commit d4f0807 into tari-project:development Aug 4, 2023
sdbondi added a commit to sdbondi/tari that referenced this pull request Aug 10, 2023
…-addresses

* development:
  chore: fix windows install (tari-project#5616)
  feat: ban peer unexpected response (tari-project#5608)
  fix!: add validator mr to mining hash (tari-project#5615)
  fix: check bytes remaining on monero blocks (tari-project#5610)
  fix: duplicate tari header in monero coinbase (tari-project#5604)
  fix: monero fork attack (tari-project#5603)
  feat: add mempool min fee (tari-project#5606)
  chore(tests): large block unit tests (tari-project#5599)
  fix: miner delay attack (tari-project#5582)
  fix: peer connection to stale nodes (tari-project#5579)
  ci(fix): artifact cleanup for diag-utils (tari-project#5613)
  ci(fix): update Windows installer for Minotari (tari-project#5614)
  chore: fixes monero build (tari-project#5612)
@SWvheerden SWvheerden deleted the sw_fix_monero_build branch August 10, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants