-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify settings for native file storage #3342
Conversation
Update notes about Symfony Standard
Can you please include the pull request format in the description? |
'session' => array('save-path' => "%kernel.root_dir%/sessions"), | ||
'session' => array( | ||
'handler-id' => "session.handler.native_file"), | ||
'save-path' => "%kernel.root_dir%/sessions"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use single quotes instead of double quotes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and remove the ),
part from both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wouterj No, that's valid PHP syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there are more closing parentheses then opening ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 more to be precise :)
Ok corrections incorporated. |
Hey Drak! I need your help to clarify a little bit more. Since the SE uses What's not clear to me is the difference between the Symfony Framework and the SE. Though not technically the same, in practice, these are the same. I'm also not sure what configuration for the If you can clarify for me, that would be awesome :). I want to give users a very direct "this is the default" statement. Thanks! |
The SE comfiguration has changed in https://github.com/symfony/symfony-standard/pull/606/files We've called that 'the default of the SE'. The original default is the native file handler. As you can see, if handler_id is empty it defaults to the handler from php.ini |
means that when you clear the cache, any current sessions will also be | ||
deleted. | ||
By default, Symfony stores the session data in files in the cache | ||
directory ``%kernel.cach_dir%/sessions``. This means that when you clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cache_dir
Clarify settings for native file storage
Thanks Drak for taking this on and everyone else for the tweaks and clarifications! I've merged this in and proposed some further changes at #3404 Thanks! |
…ectory details (weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- [#3276] Trying to further clarify the session storage directory details Hi guys! This continues after #3342. Basically, it's confusing the symfony/symfony has a different default than the Symfony SE. However, I agree with Wouter that most framework readers are probably SE users. My strategy is simply to show people which configuration causes which situation. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all (or 2.3+) | Fixed tickets | #3276 Thanks! Commits ------- adc57be [#3404] Adding a few comments, per @wouterj f094237 [#3276] Trying to further clarify the session storage directory details
Refs #3276 #3281