-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session default handler #3276
Comments
Why is it obsolete? This is still the way to configure using userland. Additionally, the documentation is also not for Symfony Standard but Symfony Full Stack Framework. There is no documentation for the symfony standard edition. |
First of all, the article is not obsolete, it only needs some minor rewrites. What needs to be done:
|
@wouterj The change was only made to Symfony standard, not Symfony (nor should be) where the default is |
@Drak but 99% of our readers use the SE, so we need to not confuse them. So, let's do it the other way around: Leave the article as is and add a note telling people that as of Symfony 2.4, the SE defaults to the native session handler. |
@Drak : If the documentation is strictly about @wouterj : By "obsolete" I meant the approach, not the content itself. We can for sure re-write it but it would just become a description of a configuration directive of a given session handler. I'm under the impression this cookbook was made in order to tackle a very particular issue : people using the standard edition and loosing session data when deploying their app or clearing the cache. Using a custom symfony edition or making its own is a very "advanced" task, people doing this should have enough knowledge of the framework to understand what's going on here without the need of a cookbook entry. |
@bamarni The documentation is for Symfony Full Stack Framework, unless it's the components/ docs when it's about the components. Sf Standard Edition is just an example project. Take a look at #3281 which I added for clarity about the feature anyhow. This feature goes back to |
…ectory details (weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- [#3276] Trying to further clarify the session storage directory details Hi guys! This continues after #3342. Basically, it's confusing the symfony/symfony has a different default than the Symfony SE. However, I agree with Wouter that most framework readers are probably SE users. My strategy is simply to show people which configuration causes which situation. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all (or 2.3+) | Fixed tickets | #3276 Thanks! Commits ------- adc57be [#3404] Adding a few comments, per @wouterj f094237 [#3276] Trying to further clarify the session storage directory details
Since the clarifications were added, this can be closed right? @weaverryan @wouterj @Drak |
Since symfony/symfony-standard#606 has been merged, http://symfony.com/doc/current/cookbook/session/sessions_directory.html cookbook entry is obsolete.
I don't want to argue about the change per se as it's pointless and it's just a default value anyway, but I think it makes the documentation messy :
symfony/framework-standard-edition
andsymfony/symfony
provide 2 different default values, which of those packages is covered by the official documentation?Should we do something about this? Personally I suggest to either backport this commit to 2.3 or postpone it to 3.0.
cc @fabpot @pulzarraider @Drak
The text was updated successfully, but these errors were encountered: