Clarify settings #3281
Closed
Clarify settings #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| ``session.save_path`` where appropriate. | ||
|
|
||
| PHP stock installation usually defaults to the ``files`` handler although this may not be | ||
| the case. |
There was a problem hiding this comment.
I would prefer to add this at the beginning
|
This needs to be merged in 2.3, as 2.1 and 2.2 are deprecated and not maintained anymore |
|
Why, it still valid for Symfony |
|
Yes, but the code of 2.0, 2.1 and 2.2 will also not be updated, and we decided to follow that for the docs too |
|
Yes this PR makes it more clear, I still think that the first sentence ("By default, ...") is ambiguous though (because of the SE). What about something like this : Then adding a note explaining how to check the configured session handler : |
| @@ -8,6 +8,17 @@ By default, Symfony stores the session data in the cache directory. This | |||
| means that when you clear the cache, any current sessions will also be | |||
| deleted. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If the ``session`` configuration key set to ``~``, Symfony will use the | |||
|
@bamarni I see you points but this entry IS only about the file storage handler. I'll adapt your text, |
Update notes about Symfony Standard
ghost
deleted the
|
Rebased to 2.3 in new PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3276