Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 5343: Fix GCC v14 not finding std::find() #1672

Closed
wants to merge 2 commits into from
Closed

Bug 5343: Fix GCC v14 not finding std::find() #1672

wants to merge 2 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Feb 13, 2024 •
edited by rousskov
Loading 

Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677.

rousskov and others added 2 commits February 12, 2024 11:16
@rousskov
Bug 5343: Fix GCC v14 build
9e63926 
    Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677 that updated
src/helper/Reply.cc.
@kinkie
include header across the board
d0a6da1
@kinkie
Copy link
Contributor Author

kinkie commented Feb 13, 2024

Completes PR #1670

Note that the build still fails on gcc 14 due to other issues (InstanceId visibility)

@squid-anubis squid-anubis added the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Feb 13, 2024
@yadij
Copy link
Contributor

yadij commented Feb 13, 2024

I have InstanceId fix testing now. No need to hold these PRs for it.

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Feb 13, 2024
@yadij yadij mentioned this pull request Feb 13, 2024
Closed
@squid-anubis squid-anubis removed the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Feb 13, 2024
@yadij yadij changed the title Bug 5343: Fix GCC v14 not finding std::find Bug 5343 pt1: Fix GCC v14 not finding std::find Feb 13, 2024
@uhliarik
Copy link
Contributor

I have InstanceId fix testing now. No need to hold these PRs for it.

Hey Yadi, it was meanwhile reported as alleged g++ bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113908

@yadij yadij mentioned this pull request Feb 13, 2024
Closed
@rousskov rousskov changed the title Bug 5343 pt1: Fix GCC v14 not finding std::find Bug 5343: Fix GCC v14 not finding std::find() Feb 13, 2024
rousskov
rousskov approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for completing this work. In the future, please commit additional changes to the original PR branch instead of closing and opening PRs.

I have adjusted PR title to use a more common format, especially since it is not yet clear whether there will ever be a "part 2" fix for this bug. I have also adjusted PR description to fix formatting (by copying #1670 description).

@rousskov rousskov removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Feb 13, 2024
squid-anubis pushed a commit that referenced this pull request Feb 13, 2024
@kinkie @squid-anubis
Bug 5343: Fix GCC v14 not finding std::find() (#1672)
0002264 
    Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Feb 13, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Feb 13, 2024

Thank you for completing this work. In the future, please commit additional changes to the original PR branch instead of closing and opening PRs.

I don't have write access to that branch; that was my first attempt in fact.

I have adjusted PR title to use a more common format, especially since it is not yet clear whether there will ever be a "part 2" fix for this bug. I have also adjusted PR description to fix formatting (by copying #1670 description).

Thanks!

@yadij yadij added the backport-to-v6 maintainer has approved these changes for v6 backporting label Feb 13, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Feb 13, 2024
yadij pushed a commit to yadij/squid that referenced this pull request Feb 28, 2024
@kinkie @yadij
Bug 5343: Fix GCC v14 not finding std::find() (squid-cache#1672)
b82c522 
    Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677.
yadij pushed a commit that referenced this pull request Feb 28, 2024
@kinkie @yadij
Bug 5343: Fix GCC v14 not finding std::find() (#1672)
a6ff320 
    Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677.
@yadij yadij removed the backport-to-v6 maintainer has approved these changes for v6 backporting label Feb 28, 2024
@yadij yadij deleted the SQUID-111-bug5343-cannot-find-find branch February 3, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

@yadij yadij yadij approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kinkie @yadij @uhliarik @rousskov @squid-anubis