Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 5343: Fix GCC v14 build #1670

Closed
wants to merge 1 commit into from
Closed

Bug 5343: Fix GCC v14 build #1670

wants to merge 1 commit into from

Conversation

rousskov
Copy link
Contributor 

Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677.

@rousskov
Bug 5343: Fix GCC v14 build
9e63926 
    Reply.cc:198: error: no matching function for call to find(...)

The required STL header was missed in 2023 commit 27c3677 that updated
src/helper/Reply.cc.
@rousskov
Copy link
Contributor Author

@eduard-bagdasaryan, to reduce similar build failures in the future, please include the <algorithm> header in these source code files as well (when you get a chance). No rush.

$ for i in `git grep -l std::find`; do if ! grep -q '<algorithm>' $i; then echo $i; fi; done               
src/CachePeers.cc
src/ResolvedPeers.cc
src/acl/AtStepData.cc
src/auth/SchemesConfig.cc
src/cache_cf.cc
src/sbuf/List.cc
src/security/KeyData.cc

I will keep this PR marked as a Draft until then (and until it is being tested by Bug 5343 reporter).

@kinkie
Copy link
Contributor

kinkie commented Feb 13, 2024 •
edited
Loading

Any reason to delay merging? Seems pretty straightforward

I can take care of this and do the testing myself (I had observed this issue on Fedora Rawhide but hadn't gotten around to fixing it)

@kinkie kinkie mentioned this pull request Feb 13, 2024
Closed
yadij
yadij approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@yadij yadij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the initial build issue.

@yadij
Copy link
Contributor

yadij commented Feb 13, 2024

Closing as superseded by PR #1672

@yadij yadij closed this Feb 13, 2024
@squid-anubis squid-anubis added the M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels label Feb 13, 2024
@rousskov rousskov removed the M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadij yadij yadij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rousskov @kinkie @yadij @squid-anubis