Bug 5343: Fix remaining GCC v14 build issues #1673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…private within this context
... specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
This comment was marked as outdated.
This comment was marked as outdated.
kinkie
reviewed
Feb 13, 2024
rousskov
requested changes
Feb 13, 2024
Co-authored-by: Alex Rousskov <[email protected]>
yadij
added
the
S-waiting-for-PR
|
All build tests work here for my Debian environment. Waiting now on PR #1672 to go in first and the wider build farm confirmation. |
rousskov
changed the title
rousskov
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Thank you for fixing this PR. I have adjusted PR title to match #1672 and removed PR description (that contained a PR comment rather than a future commit message). IMO, the bug number is enough to link these two changes together, but I am not against referencing the first commit from the second PR as well (or even merging the two PRs into one!).
yadij
added
the
backport-to-v6
|
I can confirm that this PR fixes build failure on Fedora rawhide which contains GCC v14. Thanks for the fix! |
yadij
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Feb 14, 2024
squid-anubis
added
the
M-waiting-staging-checks
yadij
removed
the
S-could-use-an-approval
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 14, 2024
squidadm
removed
the
backport-to-v6
|
queued for backport to v6 |
yadij
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.