-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ortto Action Destination #2798
Open
xitonix
wants to merge
108
commits into
segmentio:main
Choose a base branch
from
autopilot3:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ortto Action Destination #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2668) * normalize emails before hashing per google spec * add tests for upload click conversion
…io#2660) * Intercomm change custom button name * Fixed intercomm custom button issue * Fixed intercomm custom button issue * Unit test case modified
* Added multistatus support for mixpanel * code formated: Mixpanel multistatus * Code Refactored: Mixpanel * Unit test cases added for mixpanel multistatus * Unit test cases refactored * Added code to test on stage * Added code to test on stage * Handled error response * Added body and sent on 400 error * Removed hard code value * Code refactored * Code refactored * code refactored * Features fag added for mixpanel * Updated flagon for mixpanel * Removed console logs * Added feature flag in api response of mixpanel * Added feature flag in api response of mixpanel
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* major refactor * field description changes * removing page support * fixing some tests * fixing tests * update type
* add multistatus suppport for sfmc * update multistatus tests * update error response * refactor multistatus code * update error handling * update function name, check for auth error with error code * Update error body * Update status code to match the one received from SFMC, update test case, and set success message in payload order * Update test case for success response body * Update sent key in response, add comment about SFMC Api behaviour
* Worked on adding multistatus support on amazon-amc * removed unnecesary changes * TTL must be less than or equal to 34300800 * Refactored Code and handle multistatus for success and failure * Exception Handling for 401 --------- Co-authored-by: Gaurav Kochar <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…mentio#2665) * feat(heap): update browser destination code to load heap js v5 script * remove try/catch fallback for self-hosted * update tests * fix tests * apply deprecated trackingServer config value for backward compatibility * remove non-functional script loading mock * better backward compatibility with hjsv4 * assert heap.envId, not heap.appid
* Can pass in non american country codes. With unit tests * Adds a new 'phone_country_code' field for use specifically with phone numbers. The other country code field is for use with addresses
…= journey_step (segmentio#2691) * adding additional computation_class choice to support Journeys * spelling correction * submitting types
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…segmentio#2764) * Updated list id in getAudience of klaviyo * Updated default values for list_id in klaviyo * Description changed for audienceFields * Description changed for audienceFields
* updates clean script to include nx reset * Update README.md * Adds clean-build command
* Update protobuf-es * Update protofile.ts --no-verify * Fix Uses and Tests * Comment Tests * Properly mock protobuf * Fix broken import * Fix tests --------- Co-authored-by: Valerie Ernst <[email protected]>
…egmentio#2745) * custom param support for webhook-extensible * custom params changes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Add test case for smart hashing with flag - Add slug in hashing util to bypass flag check
…arty-dv360 (segmentio#2779) * Smart hashing utils added in first-party-dv360 * Updated unit test cases * Updated unit test cases
- Update test case
…in Yahoo audience (segmentio#2783) * Implemented smart hashing utilities * Updated unit test cases * Nit: Updated unit test case title
…gmentio#2787) Co-authored-by: Gaurav Kochar <[email protected]>
* Braze regions and v5.7 * yarn.lock
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tio#2711) * Deprecates existing data extension ID and key fields in favor of a future hook output data extension ID * Scaffolds data extension creation hook * Can successfully create a data extension in SFMC * Addresses build errors * Revert to original extendRequest auth method * Manually pulls accessToken prior to every data extension creation request * Scaffolds operation selector. Generating types not working as expected for hook inputs * WIP - flatten structure of generated hook input and output types * Generates new types for LinkedIn & fixes build errors related to those new types * New generated types schema Implements selection request Allows user to pass a query value to dynamic fields. Implements SFMC data extension search field Pass query to executeDynamicField in local tester * WIP - dynamic keys for columns * Prioritizes using the hook output data extension ID where it exists * Removes hardcoded temp ID for dynamic data extension fields lookup * Adds all possible field types to choices when creating the data extension * Adds dynamic values field, filters to only show relevant columns * Removes unused dataExtensionKey field. Updates label and description for data extension hook to communicate the operation choice better * Installs xml-js package * WIP - can fetch a list of categories using SOAP API * Fixes build for getting categories dynamic field * Sets Fields to dynamic. Attempts to pull data extension ID from payload/mapping directly * Removes unused and incorrect hook output reference * Generates types * Fixes build. removes .only from unit test * Adds retlOnMappingSave hook. Refactors to import the entire hook definition from sfmc-properties.ts * Updates the 'Email' choice to 'EmailAddress', which is what salesforce expects * length is no longer required for a field * Adds optional scale property so that 'Decimal' type fields can be defined * Implementation of isSendable + the params it requires * generates types * Upgrade Facebook API in Facebook Custom Audience (Actions) (segmentio#2742) Co-authored-by: Gaurav Kochar <[email protected]> * expose SyncModeDefinition in actions-core to make it compatible with action-cli (segmentio#2758) * [Smart Hashing] [LinkedIn Conversions] Use Smart Hashing Util for Hashing Email (segmentio#2759) * - Use smart hashing util for hashing email - Add test case for smart hashing util * update destination slug in processHashing * New amazon-eventbridge destination (segmentio#2760) * New amazon-eventbridge destination * yarn install * remove unused source_id variable * Fixed based on PR comments * Enabled CI for both v18 and v22 (segmentio#2763) * register amazon eventbridge (segmentio#2767) * Publish (segmentio#2768) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [MAIN] [STRATCONN-5376] Klaviyo action destination sync failed issue. (segmentio#2764) * Updated list id in getAudience of klaviyo * Updated default values for list_id in klaviyo * Description changed for audienceFields * Description changed for audienceFields * Fixes an issue with schema validation when a field is not included in a mapping (segmentio#2772) * Pulls id from retl hook to use for event delievery * pulls data extension ID for retl in dynamic fields * Adds ? for reference safety when pulling data extension IDs * Removes isSendable support * Removes unused and empty type * Removes console.log * WIP - isSendable & data retention properties when creating the extension * Sendable working * Removes WIP data retention support, it wasn't working right * Updates descriptions for isSenable input fields * Is Sendable should only be shown when operation is create --------- Co-authored-by: Innovative-GauravKochar <117165746+Innovative-GauravKochar@users.noreply.github.com> Co-authored-by: Gaurav Kochar <[email protected]> Co-authored-by: Arijit Ray <[email protected]> Co-authored-by: harsh-joshi99 <[email protected]> Co-authored-by: mayur-pitale <[email protected]> Co-authored-by: Sayan Das <[email protected]> Co-authored-by: rvadera12 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankit Gupta <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.