Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating smart code snippet to not cause opacity 0 in hide element style #2686

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

segment-anthony
Copy link
Contributor

There was a bug in VWO that was fix in legacy repository to which caused a 'flashing' issue. This was caused by the hide element style where opacity 0 was causing a quick 'flash' in the website.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.14%. Comparing base (fdcc03e) to head (aa5b6dd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2686       +/-   ##
===========================================
- Coverage   78.52%   33.14%   -45.39%     
===========================================
  Files        1033       14     -1019     
  Lines       18702      694    -18008     
  Branches     3548      115     -3433     
===========================================
- Hits        14686      230    -14456     
+ Misses       2824      464     -2360     
+ Partials     1192        0     -1192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment
Copy link
Contributor

hi @segment-anthony thanks for raising this.
Is there any way you can test that this works before I deploy it on Monday?
With a PR like this I can't review the code in a meaningful way (I won't understand what the change it), so to reduce risk it's best to have some testing done. Would this be possible?

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jan 17, 2025

Regarding testing. cc @segment-anthony
@seg-leonelsanches indicated that he tested this PR: #2654
which is identical this current new PR, apart from a css single line.

image

Screen.Recording.2025-01-17.at.15.11.24.mov

@joe-ayoub-segment joe-ayoub-segment merged commit b12df36 into main Jan 20, 2025
15 of 18 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the vwo-opacity-fix branch January 20, 2025 11:58
xitonix pushed a commit to autopilot3/segment-action-destinations that referenced this pull request Mar 16, 2025
julesbravo pushed a commit to Stodge-Inc/segment-destination that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants