Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinkedIn Conversions] Bumps linkedin version to 202411 since 202401 has been deprecated #2689

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

nick-Ag
Copy link
Member

@nick-Ag nick-Ag commented Jan 17, 2025

The LinkedIn Marketing API version we use, 202401 has been/will be deprecated soon. This PR updates to use the most up to date version: 202411.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

Tested every request in local:

Stream Conversion:
Screenshot 2025-01-17 at 12 11 01 PM

Stream Conversion (Batch):
Screenshot 2025-01-17 at 12 13 10 PM

Dynamic Conversion Rule ID Dropdown:
Screenshot 2025-01-17 at 12 19 33 PM

Dynamic Ad Account ID Dropdown:
Screenshot 2025-01-17 at 12 21 03 PM

Create a Conversion Rule hook:
Screenshot 2025-01-17 at 12 23 58 PM

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (fdcc03e) to head (2bc6aff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files        1033     1033           
  Lines       18702    18702           
  Branches     3548     3548           
=======================================
  Hits        14686    14686           
  Misses       2824     2824           
  Partials     1192     1192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-Ag nick-Ag changed the title [wip dont review][LinkedIn Conversions] Bumps linkedin version to 202411 since 202401 has been deprecated [LinkedIn Conversions] Bumps linkedin version to 202411 since 202401 has been deprecated Jan 17, 2025
@nick-Ag nick-Ag marked this pull request as ready for review January 17, 2025 22:24
@nick-Ag nick-Ag requested a review from a team as a code owner January 17, 2025 22:24
@maryamsharif
Copy link
Contributor

maryamsharif commented Jan 17, 2025

Was there any major changes/updates between the versions that we should be aware of?

@nick-Ag
Copy link
Member Author

nick-Ag commented Jan 17, 2025

Was there any major changes/updates between the versions that we should be aware of?

I read thru the change logs and there are new optional features related to the Conversions API, but nothing new is required of us.

@nick-Ag nick-Ag merged commit 2e9eff3 into main Jan 17, 2025
14 checks passed
@nick-Ag nick-Ag deleted the linkedin-version-bump branch January 17, 2025 22:42
xitonix pushed a commit to autopilot3/segment-action-destinations that referenced this pull request Mar 16, 2025
julesbravo pushed a commit to Stodge-Inc/segment-destination that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants